Ticket #1009: bellman-ford-neg-cycle.patch

index.htm

@@ -341 +341 @@
                               <tt>vis.initialize_vertex</tt> for each vertex
                               during initialization.</li>
 
+                              <li><a
+                              href="libs/graph/doc/bellman_ford_shortest.html"><tt>bellman_ford_shortest_paths</tt></a>:
+                              fixed a bug where certain negative
+                              cycles were not correctly detected.</li>
+
                               <li><b>Note:</b> the name of the
                               compiled library for the <a
                               href="libs/graph/doc/read_graphviz.html">GraphViz
@@ -350 +355 @@
                               conventions.</li>
 
                               <li>See the <a href=
-                              "libs/graph/doc/history.html#1.34.0">complete
+                              "libs/graph/doc/history.html#1.34.1">complete
                               revision history</a> for more information.</li>
                             </ul>
                           </li>

libs/graph/doc/history.html

@@ -76 +76 @@
 <h2>Changes by version</h2>
 <a name="by-version">
 <ul>
+  <a name="1.34.1"></a><li>Version 1.34.1</br><b>Bug Fixes</b><br>
+  <ul>
+     <li><a href="bellman_ford_shortest.html"><tt>bellman_ford_shortest_paths</tt></a>: fixed a bug where certain negative cycles were not correctly detected.</li>
+  </ul>
   <a name="1.34.0"></a><li>Version 1.34.0<br><b>New algorithms and components</b>
     <ul>
       <li><a href="maximum_matching.html"><tt>edmonds_maximum_cardinality_matching</tt></a>, from Aaron Windsor.</li>

boost/graph/relax.hpp

@@ -22 +22 @@
     template <class T>
     struct closed_plus
     {
-      // std::abs just isn't portable :(
-      template <class X>
-      inline X my_abs(const X& x) const { return x < 0 ? -x : x; }
-
       T operator()(const T& a, const T& b) const {
         using namespace std;
-        T inf = (numeric_limits<T>::max)();
-        if (b > 0 && my_abs(inf - a) < b)
-          return inf;
-        return a + b;
+        T zero(0);
+        T result = a + b;
+        if (result < zero && a >= zero && b >= zero)
+          return (numeric_limits<T>::max)();
+        return result;
       }
     };