Boost C++ Libraries: Ticket #10196: thread_specific_ptr does not support void*

attachment set

Tue, 15 Jul 2014 00:55:03 GMT

attachment → tss_ptr_void.diff

patch using shared_ptr's "private" helpers

viboes — Tue, 15 Jul 2014 17:53:09 GMT

What is the value of boost::detail::sp_dereference< void >::type ?

owner, status changed

viboes — Tue, 15 Jul 2014 17:53:24 GMT

owner changed from Anthony Williams to viboes
status new → assigned

Tue, 15 Jul 2014 18:01:20 GMT

Replying to viboes:

What is the value of boost::detail::sp_dereference< void >::type ?

void.

boost::detail::sp_dereference is used by shared_ptr internally to implement shared_ptr<void>.get. shared_ptr is the underlying implementation of thread_specific_ptr.

viboes — Wed, 23 Jul 2014 21:25:28 GMT

Would the following line (*) compile?

        void operator*() const
        {
            return *get(); // (*)
        }

Please, could you add a test case?

viboes — Wed, 23 Jul 2014 21:35:46 GMT

Well it seems that this compiles, but I'm getting these warnings

clang-darwin.compile.c++ ../../../bin.v2/libs/thread/test/test_tss_lib.test/clang-darwin-3.2_11/debug/threading-multi/test_tss.o
In file included from test_tss.cpp:13:
../../../boost/thread/tss.hpp:42:17: warning: cannot delete expression with pointer-to-'void' type 'void *'
                delete static_cast<T*>(data);
                ^      ~~~~~~~~~~~~~~~~~~~~~
../../../boost/thread/pthread/thread_heap_alloc.hpp:17:24: note: in instantiation of member function 'boost::thread_specific_ptr<void>::delete_data::operator()' requested here
            return new T();
                       ^
../../../boost/thread/tss.hpp:68:21: note: in instantiation of function template specialization 'boost::detail::heap_new<boost::thread_specific_ptr<void>::delete_data>' requested here
            cleanup(detail::heap_new<delete_data>(),detail::do_heap_delete<delete_data>())
                    ^
test_tss.cpp:51:34: note: in instantiation of member function 'boost::thread_specific_ptr<void>::thread_specific_ptr' requested here
boost::thread_specific_ptr<void> tss_void;
                                 ^
1 warning generated.

How do you want to use it?

Wed, 23 Jul 2014 21:53:11 GMT

Replying to viboes:

Well it seems that this compiles, but I'm getting these warnings

clang-darwin.compile.c++ ../../../bin.v2/libs/thread/test/test_tss_lib.test/clang-darwin-3.2_11/debug/threading-multi/test_tss.o
In file included from test_tss.cpp:13:
../../../boost/thread/tss.hpp:42:17: warning: cannot delete expression with pointer-to-'void' type 'void *'
                delete static_cast<T*>(data);
                ^      ~~~~~~~~~~~~~~~~~~~~~
../../../boost/thread/pthread/thread_heap_alloc.hpp:17:24: note: in instantiation of member function 'boost::thread_specific_ptr<void>::delete_data::operator()' requested here
            return new T();
                       ^
../../../boost/thread/tss.hpp:68:21: note: in instantiation of function template specialization 'boost::detail::heap_new<boost::thread_specific_ptr<void>::delete_data>' requested here
            cleanup(detail::heap_new<delete_data>(),detail::do_heap_delete<delete_data>())
                    ^
test_tss.cpp:51:34: note: in instantiation of member function 'boost::thread_specific_ptr<void>::thread_specific_ptr' requested here
boost::thread_specific_ptr<void> tss_void;
                                 ^
1 warning generated.

C++11's default_delete is ill-formed for incomplete types including void.

It's boost::shared_ptr's job to decide whether deleting void* is OK or not.

How do you want to use it?

Many C APIs expose their interface types with an opaque pointer; void* is a choice. You'll need to use a customized deleter calling the C API's cleanup function.

Wed, 23 Jul 2014 21:58:22 GMT

Replying to viboes:

Please, could you add a test case?

Sorry I'm so lazy... But you can copy & paste libc++'s test on void* support:

https://searchcode.com/codesearch/view/15464587/

viboes — Sat, 26 Jul 2014 03:24:51 GMT

Replying to Zhihao Yuan <lichray@…>:

Replying to viboes:

Please, could you add a test case?

Sorry I'm so lazy... But you can copy & paste libc++'s test on void* support:

https://searchcode.com/codesearch/view/15464587/

This is a unique_ptr test. Do you have one for thread_specific_ptr?

milestone changed

viboes — Sun, 14 Sep 2014 17:36:50 GMT

milestone To Be Determined → Boost 1.57.0

Oh, I got it. It is up to the user to provide the cleanup function.

viboes — Tue, 16 Sep 2014 05:59:19 GMT

https://github.com/boostorg/thread/commit/27befdf26fbfdc977010f40b6590415a84196916

Tue, 16 Sep 2014 14:17:28 GMT

Replying to viboes:

https://github.com/boostorg/thread/commit/27befdf26fbfdc977010f40b6590415a84196916

Looks good to me.

status changed; resolution set

viboes — Tue, 23 Sep 2014 00:07:03 GMT

status assigned → closed
resolution → fixed