Boost C++ Libraries: Ticket #10204: boost::lockfree:queue: g++ -fgnu-tm and -O1/2/3 flag not working

component changed

timblechmann — Wed, 16 Jul 2014 12:44:53 GMT

component lockfree → atomic

seem to be related to boost.atomic, which was pretty much rewritten for 1.56. can you test one of the beta releases?

anonymous — Wed, 16 Jul 2014 15:21:25 GMT

With boost 1.56 I get the same error (it only uses different header files):

g++ -Idownload/modular-boost/ -O2 -fgnu-tm errtest.cpp
In file included from download/modular-boost/boost/atomic/detail/operations_lockfree.hpp:21:0,
                 from download/modular-boost/boost/atomic/detail/operations.hpp:17,
                 from download/modular-boost/boost/atomic/fences.hpp:21,
                 from download/modular-boost/boost/atomic/atomic.hpp:20,
                 from download/modular-boost/boost/atomic.hpp:12,
                 from download/modular-boost/boost/lockfree/detail/atomic.hpp:30,
                 from download/modular-boost/boost/lockfree/queue.hpp:19,
                 from errtest.cpp:1:
download/modular-boost/boost/atomic/detail/ops_gcc_atomic.hpp: In static member function ‘static v
download/modular-boost/boost/atomic/detail/ops_gcc_atomic.hpp:67:39: error: inlining failed in cal
 BOOST_FORCEINLINE BOOST_CONSTEXPR int convert_memory_order_to_gcc(memory_order order) BOOST_NOEXC
                                       ^
download/modular-boost/boost/atomic/detail/ops_gcc_atomic.hpp:81:90: error: called from here
         __atomic_store_n(&storage, v, atomics::detail::convert_memory_order_to_gcc(order));

olli — Fri, 01 Aug 2014 07:05:48 GMT

replace BOOST_FORCEINLINE by inline (in file boost/atomic/detail/gcc-atomic.hpp, line 35) -> code compiles

cc set

Andrey Semashev — Fri, 01 Aug 2014 08:44:37 GMT

cc Andrey.Semashev@… added

I cannot reproduce this with gcc 4.8.2 but it shows with 4.7.3.

BOOST_FORCEINLINE is crucial in Boost.Atomic, it cannot be replaced with inline lightly. For now I don't have a solution for this, so I'm afraid at least 1.56 will be released with this problem.

Andrey Semashev — Fri, 01 Aug 2014 08:56:21 GMT

BTW, this gcc bug seems to be related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53991

olli — Fri, 01 Aug 2014 10:08:50 GMT

Replying to andysem:

I cannot reproduce this with gcc 4.8.2 but it shows with 4.7.3.

I can reproduce the error with gcc 4.8.2 - using boost::atomic<> and __transaction_atomic in the same app

BOOST_FORCEINLINE is crucial in Boost.Atomic, it cannot be replaced with inline lightly.

could you explain it why it is crucial, please

Andrey Semashev — Fri, 01 Aug 2014 10:16:24 GMT

Replying to olli:

I can reproduce the error with gcc 4.8.2 - using boost::atomic<> and __transaction_atomic in the same app

I don't have experience with gcc transactions, but as far as I understand atomic ops are not transaction safe and therefore should not be used inside transactions.

BOOST_FORCEINLINE is crucial in Boost.Atomic, it cannot be replaced with inline lightly.

could you explain it why it is crucial, please

It is commented in boost/atomic/detail/ops_gcc_atomic.hpp. In short, atomic<> functions must be inlined so that the compiler is able to see memory order arguments as constants. Otherwise it behaves as if seq_cst was specified.

olli — Fri, 01 Aug 2014 10:48:54 GMT

Replying to andysem:

Replying to olli:

I can reproduce the error with gcc 4.8.2 - using boost::atomic<> and __transaction_atomic in the same app

I don't have experience with gcc transactions, but as far as I understand atomic ops are not transaction safe and therefore should not be used inside transactions.

I do not use atomics inside __transaction_atomic - only some parts of the code using atomics (e.g. spinlocks) are replaced by __transaction_atomic

status changed; resolution set

Andrey Semashev — Wed, 14 Sep 2016 19:33:16 GMT

status new → closed
resolution → wontfix

I don't think we will be able to work around this.