Boost C++ Libraries: Ticket #10228: boost::filesystem::path::parent_path crashes with static link

component changed; owner set

anonymous — Wed, 23 Jul 2014 05:13:50 GMT

owner set to Beman Dawes
component None → filesystem

status changed

Beman Dawes — Fri, 25 Jul 2014 00:09:19 GMT

status new → assigned

I have not been able to reproduce the problem. Your test program runs fine for me for both static and shared linking. I'm testing on Ubuntu 14.4 LTS with gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2. Using b2 (i.e. bjam) to do the build.

How are you doing the build? What does your command line look like?

Thanks,

--Beman

anonymous — Fri, 25 Jul 2014 09:15:48 GMT

to install boost,
1. wget ...
2. gzip ...
3. tar ...
4. ./bootstrap.sh
5. ./b2 ; ./b2 install
to compile the program
shared link,
g++ exeinfo.cpp -lboost_filesystem -lboost_system
static link,
g++ exeinfo.cpp -lboost_filesystem -lboost_system -static

status changed; resolution set

Beman Dawes — Sun, 27 Jul 2014 14:53:31 GMT

status assigned → closed
resolution → worksforme

I still can't reproduce the problem here, even doing the Boost install and test program build on a virtual machine exactly as you did.

Is it possible your locale is somehow messed up? For example, is your LANG environmental variable set to a valid locale?

Have you tried on a freshly built virtual machine? If the test program works statically in that environment, perhaps you can figure out what is different about the environment where the program is failing.

I'm closing the issue as "worksforme" since after quite a bit of effort I still can't reproduce the problem.

--Beman

Sun, 27 Jul 2014 15:28:21 GMT

my LANG environment variable has been set to LANG="en_US.UTF-8", which is default by my ubuntu installation. i am now trying with other distributions, but would you mind to tell me your environment variables, so i can figure out if anything different. following is the environment variables may be related.

declare -x LANG="en_US.UTF-8"
declare -x LANGUAGE="en_US"
declare -x LC_ADDRESS="zh_CN.UTF-8"
declare -x LC_IDENTIFICATION="zh_CN.UTF-8"
declare -x LC_MEASUREMENT="zh_CN.UTF-8"
declare -x LC_MONETARY="zh_CN.UTF-8"
declare -x LC_NAME="zh_CN.UTF-8"
declare -x LC_NUMERIC="zh_CN.UTF-8"
declare -x LC_PAPER="zh_CN.UTF-8"
declare -x LC_TELEPHONE="zh_CN.UTF-8"
declare -x LC_TIME="zh_CN.UTF-8"

Sun, 27 Jul 2014 19:11:32 GMT

detail frame is

#0  0x0000000000431555 in std::locale::locale(std::locale const&) ()
#1  0x0000000000403ce4 in boost::filesystem::path::imbue (loc=...) at libs/filesystem/src/path.cpp:918
#2  0x0000000000403c57 in boost::filesystem::path::codecvt () at libs/filesystem/src/path.cpp:911
#3  0x0000000000404200 in boost::filesystem::path::path<char const*> (this=0x7fffffffe3e0, begin=0x767bd8 "/root/a.out",
    end=0x767bdd "/a.out") at ./boost/filesystem/path.hpp:167
#4  0x000000000040249f in boost::filesystem::path::parent_path (this=0x7fffffffe3d0) at libs/filesystem/src/path.cpp:352
#5  0x0000000000401509 in run () at exeinfo.cpp:32
#6  0x00000000004019a7 in ABC::ABC (this=0x74de60 <ABC::instance()::i>) at exeinfo.cpp:41
#7  0x00000000004019df in ABC::instance () at exeinfo.cpp:47
#8  0x00000000004016d5 in __static_initialization_and_destruction_0 (__initialize_p=1, __priority=65535) at exeinfo.cpp:50
#9  0x00000000004016f1 in _GLOBAL__sub_I_main () at exeinfo.cpp:55
#10 0x000000000045d5e7 in __libc_csu_init ()
#11 0x000000000045d089 in __libc_start_main ()
#12 0x00000000004012d7 in _start ()

according to std lib implementation, the copy constructor of locale will copy the _M_impl pointer and add reference to it.

00058   locale::locale(const locale& __other) throw()
00059   : _M_impl(__other._M_impl)
00060   { _M_impl->_M_add_reference(); }

so if the path_locale._M_impl is nullptr, i.e. the constructor of path_locale has not been called, the copy constructor will crash. when the user trying to use static variable in functions, the logic may call the path::imbue before the constructor of path_locale, and cause the trouble.

i have tried to provide a fix, the principle is to define path_locale as a static variable in a function just as what windows implementation does. which can resolve the bug. the diff is,

root@hzj-ubuntu-1c:~# diff downloads/boost_1_55_0/libs/filesystem/src/path.cpp path.cpp
868,872c868
<   inline std::locale path_locale()  // initialized by path::codecvt() below
<   {
<       static std::locale loc;
<       return loc;
<   }
---
>   std::locale path_locale;  // initialized by path::codecvt() below
922,923c918,919
<     std::locale temp(path_locale());
<     path_locale() = loc;
---
>     std::locale temp(path_locale);
>     path_locale = loc;
925c921
<       &std::use_facet<std::codecvt<wchar_t, char, std::mbstate_t> >(path_locale());
---
>       &std::use_facet<std::codecvt<wchar_t, char, std::mbstate_t> >(path_locale);

would you please have a look, if the proposal works?

thank you.

Beman Dawes — Tue, 29 Jul 2014 12:16:49 GMT

I'm having trouble applying your patch.

Please send me the complete modified path.cpp file.

Thanks,

--Beman

attachment set

Tue, 29 Jul 2014 12:58:46 GMT

attachment → path.cpp

Tue, 29 Jul 2014 13:02:26 GMT

attached, thank you.

Wed, 30 Jul 2014 08:33:30 GMT

i saw the issue has been fixed in 1.56, thank you for your time.

milestone changed

Beman Dawes — Thu, 07 Aug 2014 13:00:00 GMT

milestone To Be Determined → Boost 1.56.0