status changed; resolution set

Beman Dawes — Wed, 03 Sep 2014 21:59:00 GMT

status new → closed
resolution → fixed

Fixed. Thanks!

Here is the commit message:

Fix #10354 from Juan Alday. As he pointed out, the declaration (in detail/utf8_codecvt_facet.hpp) and definition (in detail/utf8_codecvt_facet.ipp) need to use the same signature.

Reapply Marshall Clow's [SVN r81616] and [SVN r81877] from November and December, 2012, as these appear to correctly supply const for the msvc/dinkumware library (since fixed) that used a do_length() first argument.

Revert the portion of [SVN r86722] that removed BOOST_CODECVT_DO_LENGTH_CONST from the do_length() signature in utf8_codecvt_facet.ipp so that it stays in sync with utf8_codecvt_facet.hpp. For the same reason, copy the IBMCPP workaround from utf8_codecvt_facet.ipp to utf8_codecvt_facet.hpp.

Verified all libraries (filesystem, log, program_options, property_tree, serialization) that use utf8_codecvt_facet passed all tests before, and then after, these changes.

Also applied minor edits to the use comments embedded in utf8_codecvt_facet.hpp.

--Beman

status changed; resolution deleted

Robert Ramey — Fri, 05 Sep 2014 13:57:36 GMT

status closed → reopened
resolution fixed

After the original changes the test_array_warchive test in the serialization library test suite began to fail for all gcc compilers.

After much time spent investigating this, I concluded that there were collisions in the the codecvt in the standard library and the boost one and I created [SVN r86722] to fix it.

Now that's in backed out, this test is again failing. See http://www.boost.org/development/tests/develop/developer/serialization.html

On possible confusion is that the gcc compilers have an optional switch to select C++03 or C++11. It's not clear which testers use which switch.

So I don't think we're done yet. Good luck with this.

Robert Ramey

Boost C++ Libraries: Ticket #10354: inconsistent declaration of do_length in boost/detail/utf8_codecvt_facet.hpp due to missing BOOST_WORKAROUND

status changed; resolution set

status changed; resolution deleted