Boost C++ Libraries: Ticket #10388: null character at end of string from filesystem::temp_directory_path

status changed; resolution set

Beman Dawes — Sat, 10 Jan 2015 14:34:14 GMT

status new → closed
resolution → fixed

Fixed. A path member function remove_trailing_separator() was added publicly since this may be useful to users.

Thanks,

--Beman

status, version changed; resolution deleted

anonymous — Wed, 29 Jul 2015 11:03:08 GMT

status closed → reopened
version Boost 1.56.0 → Boost 1.57.0
resolution fixed

The bug is not fixed as of version 1.57. It has nothing to do with `trailing separator'.

Again: `The null character at end of string causes very interesting bugs ...'.

The tested solution: replace lines

buf.pop_back();

path p(buf.begin(), buf.end());

with

path p(buf.begin());

in file \libs\filesystem\src\operations.cpp

The problem is that string returned by GetTempPathW sometimes contain 2 null characters. That means that 1 null character becomes a part of returned path in buggy code, because the code makes assumption that returned string contains exactly 1 null character.

...

Is explanation ok? Or should I just send a patch?

status changed; resolution set

Beman Dawes — Sat, 29 Aug 2015 12:15:19 GMT

status reopened → closed
resolution → fixed

Oops! The trailing_separator comment applied to a different ticket.

Are you sure you are looking at the current state of filesystem? GetTempPathW is no longer used. Please take a look at the develop branch at https://github.com/boostorg/filesystem, and do submit a patch if you think there is still a problem, and then reopen the ticket again.

Thanks,

--Beman