Boost C++ Libraries: Ticket #10488: Compilation of serializing shared_ptr fails

visa.jokelainen@… — Wed, 10 Sep 2014 12:56:00 GMT

The problem sounds a lot like regression of this previous ticket: https://svn.boost.org/trac/boost/ticket/3123

Robert Ramey — Mon, 15 Sep 2014 15:08:46 GMT

Actually this change looks like an improvement to me.

a const TestClass is something that shouldn't be modifiable

ia >> cPtr would do just that.

I don't remember any specific change which would affect this, but the current behavior seems to be the correct one to me.

status changed; resolution set

Robert Ramey — Tue, 23 Sep 2014 20:17:27 GMT

status new → closed
resolution → duplicate

see https://svn.boost.org/trac/boost/ticket/3123

Wed, 29 Oct 2014 10:10:38 GMT

This is a regression. Not being able to serialize a shared_ptr<const Object> is indeed very painful. Ticket 3123 shows it is not absurd: imagine I have a

typedef map<string,shared<book>> library;

Since I do not want people to write on the books, I'd prefer a

typedef map<string,shared<const book>> library;

and be able to write/load the contents of my library.

Anyhow, it seems to be just a matter of changing line 59 of serialization/shared_ptr_helper.cpp from

  SPT<void> // address shared ptr to single instance

  SPT<const void> // address shared ptr to single instance

to regain previous behaviour (if one can check extensively).

status changed; resolution deleted

Robert Ramey — Wed, 29 Oct 2014 21:20:46 GMT

status closed → reopened
resolution duplicate

tonvandenheuvel@… — Tue, 10 Feb 2015 15:10:34 GMT

I can confirm the fix proposed by reder works for me, although I have not checked this extensively.

chris@… — Thu, 12 Mar 2015 13:59:47 GMT

This regression currently prevents building Cufflinks; the author is disinclined to work around the problem. I can't link the issue directly due to the spam trap, but google "cufflinks boost serialization".

status changed; resolution set

Robert Ramey — Thu, 12 Mar 2015 15:35:27 GMT

status reopened → closed
resolution → fixed

note: already checked into master. Correction will appear in next boost release

cc set

boost@… — Mon, 30 Mar 2015 04:08:54 GMT

cc boost@… added

Which commit fixed this problem? I would like to try to backport it to boost 1.57.0 in MacPorts.

boost@… — Tue, 31 Mar 2015 00:39:14 GMT

I tested with boost 1.58.0 beta 1, released March 16, 2015, and the problem remains.

cc changed

Thu, 09 Apr 2015 09:02:17 GMT

cc mika.fischer@… added

boost@… — Tue, 21 Apr 2015 18:10:12 GMT

I tested with boost 1.58.0, released April 17, 2015, and the problem remains.

If the fix was supposed to be to change SPT<void> to SPT<const void> in https://github.com/boostorg/serialization/blob/master/include/boost/serialization/shared_ptr_helper.hpp, that has not occurred.

anonymous — Fri, 24 Apr 2015 20:57:00 GMT

OK - I double checked - I fixed this again - I'm not sure what happened the first time

boost@… — Tue, 28 Apr 2015 21:43:39 GMT

Could you please post a link to the commit where you fixed it, so that I can backport it to boost 1.58.0 in MacPorts? Thanks.

xnox — Sun, 16 Aug 2015 10:25:09 GMT

Is this the fix for this issue?

https://github.com/boostorg/serialization/commit/010055816681a003a8090d105ea5ab385bb87bf8

Robert Ramey — Mon, 28 Sep 2015 06:17:12 GMT

I believe so