Boost C++ Libraries: Ticket #1051: MPL header ordering triggers bug

attachment set

aribrei@… — Thu, 14 Jun 2007 22:16:09 GMT

attachment → test1.cpp

Compile with -DX to trigger failure

owner set

Dave Abrahams — Wed, 11 Jul 2007 01:11:03 GMT

owner set to Aleksey Gurtovoy

Steven Watanabe — Thu, 05 Feb 2009 02:52:51 GMT

I guess the solution is "don't do that." #define X or the equivalent -DX is a bad idea, as is defining any other such short name as a macro.

status changed; resolution set

aribrei@… — Tue, 10 Feb 2009 12:29:19 GMT

status new → closed
resolution → fixed

I cannot reproduce the problem on 1.37, so it seems to be fixed, actually. But, Steven Watanabe is completely wrong, the #define X is not even related to the problem. When I reported the problem, the same error would appear without any such #define. Claiming "-DX is a bad idea" without even looking at the relevant code is a most stupid idea, as it could be easily seen from the code that "#ifdef X" was added for testing purposes.

Also, if MPL would actually use X as a define internally without first checking for its existence, that would be a bug as well. Fortunately that is not the case, and never has been.