std::iterator_traits<boost::unordered_map<K,M>::iterator>::pointer should be value_type*, not detail::ptr_node<...>

[anonymous]

The iterator type looks like:

template <typename NodePointer, typename Value>
struct iterator
    : public boost::iterator<
        std::forward_iterator_tag, Value, std::ptrdiff_t,
        NodePointer, Value&>

The NodePointer argument here (which is boost::unordered::detail::ptr_node<...>) becomes the iterator_traits<>::pointer type.

But iterator's operator->() returns Value *:

Value* operator->() const {
    return &node_->value();
}

Seems like this should be changed.

[Daniel James]

Fix in develop: ​https://github.com/boostorg/unordered/commit/99985bb1b26ea13e9a85f723cfa9369a4c9ee257

Will hopefully be included in the next release.

[anonymous]

Awesome! Thank you!