Boost C++ Libraries: Ticket #1069: _InterlockedExchange, _InterlockedExchangeAdd have wrong signature

attachment set

Thu, 28 Jun 2007 22:54:32 GMT

attachment → interlocked.patch

Patch

Thu, 28 Jun 2007 22:56:20 GMT

As suggested in the summary, the declaration of _InterlockedExchangeAdd has the same problem.

status, component, severity changed; owner set

Peter Dimov — Tue, 10 Jul 2007 00:00:47 GMT

owner set to Peter Dimov
status new → assigned
component Building Boost → smart_ptr
severity Showstopper → Problem

On which compiler are you seeing this behavior? The actual declaration in <windows.h> is as follows:

WINBASEAPI LONG WINAPI InterlockedExchange(

IN OUT LONG volatile *Target, IN LONG Value );

with the volatile correctly applied to *Target.

braden@… — Tue, 10 Jul 2007 01:47:26 GMT

The compiler is Visual C++ 7.1. The problem arises because code in another dependency has declared the function the way the Microsoft documentation recommends. Since the signatures are different, the compiler complains that an extern "C" function has been overloaded.

Peter Dimov — Sun, 15 Jul 2007 16:06:22 GMT

The Microsoft documentation is wrong in this case. If we change the code to be wrong as well, the signatures will no longer match the ones in <windows.h>. The documentation for InterlockedExchange

http://msdn2.microsoft.com/en-us/library/ms683590.aspx

correctly specifies the signature as taking LONG volatile*. BTW, you can't declare a function parameter as long * volatile, the volatile is ignored.

status changed; resolution set

Peter Dimov — Sat, 21 Jul 2007 16:43:27 GMT

status assigned → closed
resolution → invalid