qbowater@… — Fri, 06 Jul 2007 08:01:48 GMT

.hpp

-              old
+              new
     detail::basic_buffer<char_type>  buf(buffer_size);
     pair_type                        p = snk.output_sequence();
     streamsize                       total = 0;
     bool                             done  = false;
     while (!done) {
         streamsize amt;
         done = (amt = iostreams::read(src, buf.data(), buffer_size)) == -1;
+    while (true) {
+        streamsize amt = iostreams::read(src, buf.data(), buffer_size);
+        if(amt == -1)
+            break;
         std::copy(buf.data(), buf.data() + amt, p.first + total);
+        if (amt != -1)
+            total += amt;
+        total += amt;
+    }
     return total;
+}
 …
     detail::basic_buffer<char_type>  buf(buffer_size);
     non_blocking_adapter<Sink>       nb(snk);
     std::streamsize                  total = 0;
+    bool                             done = false;
+    while (!done) {
+        std::streamsize amt;
+        done = (amt = iostreams::read(src, buf.data(), buffer_size)) == -1;
+        if (amt != -1) {
+            iostreams::write(nb, buf.data(), amt);
+            total += amt;
+        }
+    while (true) {
+        std::streamsize amt = iostreams::read(src, buf.data(), buffer_size);
+        if (amt == -1)
+            break;
+        iostreams::write(nb, buf.data(), amt);
+        total += amt;
+    }
     return total;
+}

--- copy.hpp	2005-05-26 01:37:30.000000000 +0800
+++ copy1.hpp	2007-07-06 15:55:17.859375000 +0800
@@ -88,13 +88,12 @@
     detail::basic_buffer<char_type>  buf(buffer_size);
     pair_type                        p = snk.output_sequence();
     streamsize                       total = 0;
-    bool                             done  = false;
-    while (!done) {
-        streamsize amt;
-        done = (amt = iostreams::read(src, buf.data(), buffer_size)) == -1;
+    while (true) {
+        streamsize amt = iostreams::read(src, buf.data(), buffer_size);
+        if(amt == -1)
+            break;
         std::copy(buf.data(), buf.data() + amt, p.first + total);
-        if (amt != -1)
-            total += amt;
+        total += amt;
     }
     return total;
 }
@@ -109,14 +108,12 @@
     detail::basic_buffer<char_type>  buf(buffer_size);
     non_blocking_adapter<Sink>       nb(snk);
     std::streamsize                  total = 0;
-    bool                             done = false;
-    while (!done) {
-        std::streamsize amt;
-        done = (amt = iostreams::read(src, buf.data(), buffer_size)) == -1;
-        if (amt != -1) {
-            iostreams::write(nb, buf.data(), amt);
-            total += amt;
-        }
+    while (true) {
+        std::streamsize amt = iostreams::read(src, buf.data(), buffer_size);
+        if (amt == -1)
+            break;
+        iostreams::write(nb, buf.data(), amt);
+        total += amt;
     }
     return total;
 }

anonymous — Fri, 06 Jul 2007 23:04:52 GMT

I think this is the same as Trac ticket # 786

anonymous — Wed, 11 Jul 2007 04:18:54 GMT

The proposed change at ticket #786 seems a little cleaner than the change here.

component, severity changed; owner set

Peter Dimov — Sun, 22 Jul 2007 00:30:49 GMT

owner set to Douglas Gregor
component None → iostreams
severity Showstopper → Problem

owner deleted

Peter Dimov — Sun, 22 Jul 2007 00:32:57 GMT

owner Douglas Gregor removed

How did the owner become dgregor? A Trac mystery.

owner set

Marshall Clow — Thu, 27 Sep 2007 14:05:09 GMT

owner set to Jonathan Turkanis

status changed; resolution set

Jonathan Turkanis — Tue, 25 Dec 2007 08:51:48 GMT

status new → closed
resolution → fixed

Fixed in [42294] in branches/iostreams_dev, to be merged into trunk shortly. The fix is a slight modification of the suggestion in #786.

Boost C++ Libraries: Ticket #1070: [iostreams]boost\iostreams\copy.hpp line80 copy_impl

.hpp

component, severity changed; owner set

owner deleted

owner set

status changed; resolution set