severity changed

Joaquín M López Muñoz — Wed, 05 Nov 2014 07:40:03 GMT

severity Problem → Cosmetic

Added annotation at

https://github.com/boostorg/multi_index/commit/08fe6a360acf99e1732a54ef8b3114455f59116b

Could you please verify this shuts Coverity down?

status changed; resolution set

Joaquín M López Muñoz — Tue, 11 Nov 2014 19:47:20 GMT

status new → closed
resolution → fixed

anonymous — Thu, 27 Aug 2015 18:12:30 GMT

This isn't cosmetic: if the default constructor is used to create an instance, then the member variable "node" isn't initialized via the constructor => this can result in dereferencing an invalid pointer.

anonymous — Thu, 27 Aug 2015 18:13:28 GMT

Either initialize "node" to NULL, or delete the constructor.

Joaquín M López Muñoz — Thu, 27 Aug 2015 19:25:25 GMT

Hi anonymous,

The default constructor is needed because it is permissible (and very useful) to default initialize an iterator, so we can't just omit this constructor. When default-initialized, the iterator has a singular value according to the C++ standard terminology in [iterator.requirements.general]/5. Dereferencing a singular value is undefined behavior, so the programmer is not allowed to do it regardless of whether the value of the pointer is null or not. My reluctance to initialize to null comes from the fact that we're introducing a run-time penalty in default construction (even if a negligible one) that, in the best of cases, will only expose undefined behavior more nicely.

Anyway, is perhaps the annotation commited in

https://github.com/boostorg/multi_index/commit/08fe6a360acf99e1732a54ef8b3114455f59116b

not silencing the Coverity warning?