Boost C++ Libraries: Ticket #10762: fixed_matrix &operator = (matrix m) wrong parameter

James Benze — Thu, 06 Nov 2014 14:48:21 GMT

Can confirm, I'm experiencing this issue as well.

James Benze — Thu, 06 Nov 2014 14:53:36 GMT

Problem is fixed by changing

fixed_matrix & operator=(matrix m)

fixed_matrix & operator=(fixed_matrix m)

Although based on the comment that this is supposed to be a move-assignment operator, the author probably really wants

fixed_matrix & operator=(fixed_matrix && m)

Otherwise...well I'm not sure how that would overload with the copy-assignment operator. Probably not nicely.

Gimmie a few minutes and I'll generate up a patch.

James Benze — Thu, 06 Nov 2014 15:28:42 GMT

Sorry for the delay, I didn't realize boost had completed the migration to git...I was bumming around the svn server, trying to figure out where all the commits went.

I made a pull request and committed it to the ublas repository...I can't link it because I guess trac doesn't let people without IDs like myself send external links, but it's pull request number 15.

attachment set

James Benze — Thu, 06 Nov 2014 15:29:55 GMT

attachment → 0001-Fix-typo-in-fixed_matrix-move-assignment.patch

James Benze — Thu, 06 Nov 2014 15:30:31 GMT

And there's a patch version of the pull request as well, just for completeness :-)

Fri, 08 May 2015 20:20:32 GMT

Patch has been accepted and the bug is fixed in the development version. This bug can be closed by someone that has the ability to close tickets.