Boost C++ Libraries: Ticket #10778: VC14 CTP4 Atomic don't compile with boost::chrono durations which are not TriviallyCopyable

cc set

raad@… — Mon, 10 Nov 2014 10:30:19 GMT

cc raad@… added

viboes — Tue, 11 Nov 2014 14:49:11 GMT

The problem is at least on the default constructor.

I added the default initialization as zero, but this is not correct.

Please, could you try the following

#if  defined   BOOST_NO_CXX11_DEFAULTED_FUNCTIONS
        BOOST_FORCEINLINE BOOST_CONSTEXPR
        duration() : rep_(duration_values<rep>::zero()) { }
#else
        duration() BOOST_NOEXCEPT = default;
#endif

You would surely need

#if  defined   BOOST_NO_CXX11_DEFAULTED_FUNCTIONS
        duration& operator=(const duration& rhs) // = default;
        {
            if (&rhs != this) rep_= rhs.rep_;
            return *this;
        }
#else
        duration& operator=(const duration& rhs) = default;
#endif

mjklaim@… — Thu, 13 Nov 2014 23:03:01 GMT

First: I uninstalled VC14 CTP4 and installed VS2015 Preview, which is the same compiler (certainly with some bugfixes). As expected I found the same issue.

Second: I applied your changes and now it compiles (it required both changes).

I will now re-compile my boost binaries with this change, see if there is any issue but I highly doubt it.

milestone changed

viboes — Fri, 05 Dec 2014 18:33:12 GMT

milestone To Be Determined → Boost 1.58.0

Any news? https://github.com/boostorg/chrono/commit/6faac3febb4e70b9f9a980d14340a37a5d7432d1 https://github.com/boostorg/chrono/commit/9885be7ec0ba5b867b0f6245de3422905ebf6b4a

mjklaim@… — Fri, 05 Dec 2014 18:38:14 GMT

I had no apparent problem with the build I was talking about so I think it works in principle, but I didn't see your patches. I can't test these patches until next week.

status changed; resolution set

viboes — Wed, 07 Jan 2015 02:35:43 GMT

status new → closed
resolution → fixed