Boost C++ Libraries: Ticket #10824: Boost.Thread 1.57 breaks Windows XP compatibility for SP2 and below.

owner changed

viboes — Fri, 28 Nov 2014 17:21:36 GMT

owner changed from Anthony Williams to timblechmann

I think it would be good that physical_concurrency calls hardware_concurrency if it can not be implemented.

Tim please, could you take care of this issue?

timblechmann — Sat, 29 Nov 2014 10:42:27 GMT

not intentional. vicente, thinking about a good fallback, i'd actually prefer to return 0 instead of calling hardware_concurrency: the reason is simple: code that depends on distinguishing the number of physical and the number of virtual processors, can rely on this. if it returns 0, the user can call hardware_concurrency.

milestone changed

viboes — Sat, 29 Nov 2014 13:29:40 GMT

milestone To Be Determined → Boost 1.58.0

Ok, no problem.

Felix, does the following covers your expectations https://github.com/boostorg/thread/pull/32 ?

Thanks Tim.

Sun, 30 Nov 2014 14:36:31 GMT

Thanks for the quick fix! :-)

status changed; resolution set

viboes — Sat, 13 Dec 2014 16:05:19 GMT

status new → closed
resolution → fixed

status changed; resolution deleted

anonymous — Fri, 19 Dec 2014 13:06:50 GMT

status closed → reopened
resolution fixed

If I'm not mistaken, comments are not allowed after the backslash in mutliline macros, so the line

|| ( BOOST_USE_WINAPI_VERSION <= BOOST_WINAPI_VERSION_WINXP ) \ // a bit too strict: Windows XP with SP3 would be sufficient

will fail to compile (at least does in VS2010).

status changed; resolution set

viboes — Sat, 20 Dec 2014 06:02:44 GMT

status reopened → closed
resolution → fixed

https://github.com/boostorg/thread/commit/8e1be55c6d560c44fb07cc497a3480527957576c