Boost C++ Libraries: Ticket #10830: Clang static analyzer warns about

anonymous — Wed, 04 Nov 2015 11:49:06 GMT

vs2015 generates an error for this in x64 release build:

c:\boost\boost_1_59_0_vs2015\x64\boost\graph\named_function_params.hpp(240): error C4172: returning address of local variable or temporary

return lookup_named_param_def<Tag, Args, param_not_found>::get(p, param_not_found());

see also http: connect.microsoft.com/VisualStudio/feedback/details/1425276/false-positive-error-c4172-returning-address-of-local-variable-or-temporary

attachment set

Fri, 04 Nov 2016 16:54:33 GMT

attachment → param_not_found_static_instance.patch

Workaround on boost 1.62 sources to get MSVC14 to compile

Fri, 04 Nov 2016 17:10:36 GMT

This also affects boost 1.62 which cannot be compiled with VS2015 (MSVC14). I attached a patch with an ugly workaround.

It adds a static instance of the param_not_found structure. A reference to this "singleton" object will be returned if necessary. As the structure itself is empty, wrong code could not do much with it. Furthermore, I imagine the whole param_not_found is just a construct to get the whole named-parameter system to work and the actual object returned will never be used in this case.

I would be happy if someone reports a nicer solution. I would also be happy to submit this as a PR in github if you want.

fmilano@… — Fri, 14 Jul 2017 17:21:24 GMT

This also affects boost 1.64 in VS2015 (MSVC14)

Tue, 14 Nov 2017 08:25:01 GMT

I am getting the same in Boost 1.65.0 and VS 2017. It's quite annoying not to be able to use "warnings as errors" because of this.

aaron@… — Wed, 14 Mar 2018 13:38:31 GMT

I get the same with Clang-5.0 on ubuntu 16.04