Boost C++ Libraries: Ticket #10838: Missing std:: qualifier for strlen calls in string_ref_test2.cpp

owner changed

Marshall Clow — Tue, 02 Dec 2014 19:14:34 GMT

owner changed from No-Maintainer to Marshall Clow

Ok, I'm confused.

<cstring> includes <string.h>, which defines strlen, right?

All that <cstring> does is using ::strlen; (which hoists it from the global namespace into namespace std)

Tue, 02 Dec 2014 20:31:56 GMT

Per the C++ standard,

D.5 C standard library headers

2 Every C header, each of which has a name of the form name.h, behaves as if each name placed in the standard library namespace by the corresponding cname header is placed within the global namespace scope. It is unspecified whether these names are first declared or defined within namespace scope (3.3.6) of the namespace std and are then injected into the global namespace scope by explicit using-declarations (7.3.3).

3 [ Example: The header <cstdlib> assuredly provides its declarations and definitions within the namespace std. It may also provide these names within the global namespace. The header <stdlib.h> assuredly provides the same declarations and definitions within the global namespace, much as in the C Standard. It may also provide these names within the namespace std. —end example ]

Wed, 25 Feb 2015 18:57:53 GMT

In standard C++, names declared in the <cname> version of the C <name.h> headers are only in namespace std. However, gcc puts the names in the global namespace.

Line 54 of this file already qualifies strlen with std:: qualifier and as seen above, there is no error message generated for this line.

54: const char *p = arg + std::strlen ( arg ) - 1;

I have just submitted a pull request for this.

Thanks.

Wed, 25 Feb 2015 18:59:58 GMT

In standard C++, names declared in the <cname> version of the C <name.h> headers are only in namespace std. However, gcc puts the names in the global namespace.

Line 54 of this file already qualifies strlen with std:: qualifier and as seen above, there is no error message generated for this line.

54: const char *p = arg + std::strlen ( arg ) - 1;

I have just submitted a pull request for this.

Thanks.

status changed; resolution set

Marshall Clow — Sat, 28 Feb 2015 06:26:12 GMT

status new → closed
resolution → fixed