Boost C++ Libraries: Ticket #10996: Thread physical_concurrency() is failing on Windows

owner changed

Niall Douglas — Wed, 04 Feb 2015 18:20:34 GMT

owner changed from Anthony Williams to Niall Douglas

viboes — Sun, 08 Feb 2015 11:16:14 GMT

Would it be enough to return

return hardware_concurrency();

instead of returning 0 in

    unsigned thread::physical_concurrency() BOOST_NOEXCEPT
    {
// a bit too strict: Windows XP with SP3 would be sufficient
#if BOOST_PLAT_WINDOWS_RUNTIME                                    \
    || ( BOOST_USE_WINAPI_VERSION <= BOOST_WINAPI_VERSION_WINXP ) \
    || ( defined(__MINGW32__) && !defined(__MINGW64__) )
        return 0;
#else

Niall Douglas — Mon, 16 Feb 2015 17:44:42 GMT

I'm a bit confused why we disable use of GetLogicalProcessorInformation() at all actually as out lowest supported platform is Windows XP SP3.

I've removed the check here so it only disables on WinRT from now on. And for WinRT it now returns hardware_concurrency(). If it passes on Mingw I'll push the fix.

Niall Douglas — Mon, 16 Feb 2015 18:04:08 GMT

Fix pushed.

milestone changed

viboes — Thu, 19 Feb 2015 08:17:42 GMT

milestone To Be Determined → Boost 1.58.0

https://github.com/boostorg/thread/commit/cf1182ee99ee1868550faac091b5f0d8b43e4dd7

status changed; resolution set

viboes — Sun, 08 Mar 2015 22:16:31 GMT

status new → closed
resolution → fixed