Boost C++ Libraries: Ticket #11035: BOOST_HAS_PTHREAD_MUTEXATTR_SETTYPE not defined for Android

attachment set

kervala@… — Mon, 16 Feb 2015 15:42:59 GMT

attachment → boost_recursive_mutex.patch

boost::recursive_mutex fix for Android

attachment set

Mon, 16 Feb 2015 15:53:51 GMT

attachment → boost_recursive_mutex.2.patch

Fix of the patch

Mon, 16 Feb 2015 16:10:31 GMT

Please ignore the first patch, I forgot to remove a #endif

attachment set

Mon, 16 Feb 2015 17:27:43 GMT

attachment → boost_recursive_mutex.3.patch

summary changed

Mon, 16 Feb 2015 17:33:01 GMT

summary BOOST_HAS_PTHREAD_MUTEXATTR_SETTYPE and BOOST_PTHREAD_HAS_TIMEDLOCK not defined for Android → BOOST_HAS_PTHREAD_MUTEXATTR_SETTYPE not defined for Android

I'm sorry, I didn't notice pthread_mutex_timedlock wasn't implemented in bionic before Android API 21, although it was defined in oldest ARM headers (a Google bug in this case).

So I updated my patch for a 3rd time :)

owner changed

viboes — Thu, 19 Feb 2015 08:15:28 GMT

owner changed from Anthony Williams to Niall Douglas

Since which version of Android the 3rd patch is valid?

Thu, 19 Feb 2015 08:27:49 GMT

Thanks for your reply :)

It's valid since Android API 3 (Android 1.5).

I checked all pthread.h header from all Android versions supported by NDK.

Niall Douglas — Thu, 19 Feb 2015 15:08:20 GMT

Just for the record, I don't think Boost should support Android before v2. But thanks for the patch, this stuff is exactly why my client funded getting a regular CI going for Android.

Thu, 19 Feb 2015 18:05:14 GMT

You're welcome :)

viboes — Thu, 19 Feb 2015 19:09:02 GMT

@Niall: if V2 is the minimal version, could this restriction be encoded on the config.hpp file.

owner, status changed

viboes — Sat, 28 Feb 2015 21:42:26 GMT

owner changed from Niall Douglas to viboes
status new → assigned

You should create a ticket and a patch for Boost Config (boost/config/posix_features.hpp).

I will fix this soon.

milestone changed

viboes — Sun, 01 Mar 2015 22:22:27 GMT

milestone To Be Determined → Boost 1.58.0

https://github.com/boostorg/thread/commit/c7bb6fa318ddc27cb1ad9497f295db2744c0f069

status changed; resolution set

viboes — Sun, 08 Mar 2015 22:16:45 GMT

status assigned → closed
resolution → fixed