Boost C++ Libraries: Ticket #11107: A lot of warnings on MSVC due to protected destructor being non-virtual

Jürgen Hunold — Thu, 12 Mar 2015 19:00:23 GMT

Full log "virtual.zip" attached. Commandline:

..\..\..\b2 -a cxxflags=-we4265 -j3 2>&1 | "C:\Program Files (x86)\git\bin\tee.exe" virtual.log

See https://msdn.microsoft.com/en-us/library/wzxffy8c.aspx for the official description. We normally make this a level 3 warning, I've changed this to an error to get clearer test result.

Raffi Enficiaud — Mon, 16 Mar 2015 22:43:19 GMT

Thanks. So I'm not addressing the trillion of warnings from error_info_container in boost.exception.

The warning for collection is indeed a true one, good catch! I am adding a virtual destructor to class dataset, which should solve most of the issues in your log.

However, this has nothing to do with the pull request in fact (and Gennadiy was right). The macro that gets activated with your change does not solve the problem I can see in this log.

owner changed

Raffi Enficiaud — Mon, 16 Mar 2015 22:47:01 GMT

owner changed from Gennadiy Rozental to Raffi Enficiaud

status changed

Raffi Enficiaud — Mon, 16 Mar 2015 22:47:16 GMT

status new → assigned

attachment set

Jürgen Hunold — Wed, 18 Mar 2015 12:30:39 GMT

attachment → virtual.zip

virtual destructor error log

Jürgen Hunold — Wed, 18 Mar 2015 12:31:27 GMT

Sorry, I had the patch still active when doing the first run. Uploaded the correct run.

Raffi Enficiaud — Wed, 18 Mar 2015 14:54:51 GMT

A quick look at this tells me that most of the warnings can be safely ignored: in fact most of the instances are not meant to be used on the heap, but rather on the stack.

I will have a deeper look tonight/tomorrow.

milestone changed

Raffi Enficiaud — Thu, 22 Jun 2017 23:04:36 GMT

milestone To Be Determined → Boost 1.65.0

status changed; resolution set

Raffi Enficiaud — Sun, 15 Dec 2019 19:16:50 GMT

status assigned → closed
resolution → fixed

Addressed by rev 13ca3e07f071ee36a0c5be5c6a0b58be7ab4637c