status changed

Peter Dimov — Sun, 22 Jul 2007 00:04:32 GMT

status new → assigned

attachment set

Fri, 24 Apr 2009 17:11:49 GMT

attachment → shared_array.patch

attachment set

Fri, 24 Apr 2009 17:12:26 GMT

attachment → simple.cpp

Test code

Fri, 24 Apr 2009 17:14:32 GMT

This patch seems to fix the problem without allowing polymorphic nonsense. I'd be happy to do further work, formatting, or test code, but I wanted to make sure I was heading in the right direction.

severity changed

Felix — Mon, 03 Oct 2011 05:02:59 GMT

severity Problem → Regression

Replying to pdimov:

http://lists.boost.org/boost-users/2007/05/28330.php

Without the const correctness of the shared_array it is not as viable as it could be for many applications. For example if a member function has "shared_array<const T>" as an argument in order to guarantee that the array of T will not be modified, then if one has a non const shared_array he cannot use this function without some possibly unportable/unsafe workaround.

version set

anonymous — Mon, 03 Oct 2011 05:06:12 GMT

version → Boost 1.47.0

Thu, 17 Nov 2011 16:50:14 GMT

Peter, could you review this issue?

Peter Dimov — Fri, 02 Nov 2012 17:41:42 GMT

(In [81149]) Implement shared_ptr<X[]>, weak_ptr<X[]>. Refs #1113.

Peter Dimov — Sat, 10 Nov 2012 00:04:51 GMT

(In [81272]) Updated shared_array to match shared_ptr. Refs #1113.

Peter Dimov — Wed, 14 Nov 2012 13:52:16 GMT

(In [81339]) Merged revision(s) 81149, 81159, 81171, 81174, 81219-81220, 81222-81224, 81226, 81229-81239, 81242, 81253, 81257-81262, 81265-81268, 81271-81272, 81275-81277, 81299-81300 from trunk: Implement shared_ptr<X[]>, weak_ptr<X[]>. Refs #1113. ........ Fix shared_ptr<T[]> EDG issues. ........ Disable make_shared<T> overloads when T is Q[]. ........ Add catch(...) clauses to sp_array_test.cpp. ........ Add allocate_shared and make_shared for shared_ptr arrays of runtime size. Fulfills need for allocate_shared_array and make_shared_array. ........ Update Jamfile.v2 to run make_shared array tests and allocate_shared array tests. ........ Fix g++ issues. ........ Add specialization of sp_if_not_array<T[N]>. ........ Rename make_shared.hpp to make_shared_object.hpp, include from make_shared.hpp. ........ Add make_shared_array_args_test.cpp. ........ Add support for make_shared of array of arrays. Correctly destroy elements and construct elements for the variadic template constructor variants. ........ Fix sp_convertible<T const[], T const[]>. ........ Update smart_ptr/detail/array_helper to have create and create_noinit for non-array case. ........ Rename sp_convertible_test.cpp to shared_ptr_convertible_test.cpp. ........ Don't treat array_helper create and create_noinit for array types as a special case. ........ Add sp_convertible_test.cpp. ........ Fix array_helper (create_noinit and use of args...). ........ Update allocate_shared and make_shared to treat multidimensional array as single dimension. Remove detail array_helper. Add detail array traits. Update tests. ........ Simplify array_deleter interface ........ Add missing semicolon. ........ Fix typo. ........ Add tests for variadic template constructors overload of array forms of make_shared and allocate_shared for multidimensional arrays and up to 9 constructor arguments. ........ Add support for shared_ptr<X[N>. ........ Add C++11 initializer list support for make_shared and allocate_shared array forms.

........ Clean up code in allocate_shared_array.hpp and make_shared_array.hpp ........ Change make_shared and allocate_shared array form semantics with initializer lists overload that takes no size. ........ Disable make_shared for arrays when the compiler doesn't support partial specialization or SFINAE. ........ For allocate_shared and make_shared: Separate test case that g++ does support yet. Remove macros testing for no partial specialization in traits. Add additional traits. ........ Actually remove test cases from make_shared_array_create_test.cpp and allocate_shared_array_create_test.cpp that g++ does not handle. ........ Add overloads to support fixed size arrays, T[N], to allocate_shared (variadic) and make_shared (variadic) and make_shared_noinit. ........ Add additional overload for make_shared and allocate_shared for arrays for fixed size arrays and initializer lists. ........ Add assertion to overload of make_shared and allocate_shared for T[N] with initializer lists. Rename detail type to be more intuitive. ........ Add allocate_shared_array_args_test.cpp. ........ Keep old definition of sp_assert_convertible when BOOST_SP_NO_SP_CONVERTIBLE is set. ........ Updated shared_array to match shared_ptr. Refs #1113. ........ Add final overload of make_shared and allocate_shared (array forms) for T[][N] with C++11 initializer lists. ........ Change traits for initializer list for g++ ........ Tidy long line formatting in allocate_shared_array.hpp and make_shared_array.hpp ........ Update tests for make_shared and allocate_shared array forms, for normal case, initializer lists, variadic template arguments, for arrays and fixed size arrays. ........ Update Jamfile.v2 with two new smart_ptr tests for allocate_shared and make_shared ........

status changed; resolution set

Peter Dimov — Sat, 08 Dec 2012 00:48:10 GMT

status assigned → closed
resolution → fixed

Boost C++ Libraries: Ticket #1113: shared_array should convert to shared_array

status changed

attachment set

attachment set

severity changed

version set

status changed; resolution set