Boost C++ Libraries: Ticket #11142: boost::date_time::period_parser::delimiter_strings setter doesn't set values https://svn.boost.org/trac10/ticket/11142 <p> The current code for <code>boost::date_time::period_parser::delimiter_strings</code> setter is: </p> <div class="wiki-code"><div class="code"><pre> <span class="kt">void</span> <span class="nf">delimiter_strings</span><span class="p">(</span><span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="p">,</span> <span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="p">,</span> <span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="p">,</span> <span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="p">)</span> <span class="p">{</span> <span class="n">m_period_separator</span><span class="p">;</span> <span class="n">m_period_start_delimeter</span><span class="p">;</span> <span class="n">m_open_range_end_delimeter</span><span class="p">;</span> <span class="n">m_closed_range_end_delimeter</span><span class="p">;</span> <span class="p">}</span> </pre></div></div><p> Up to Boost 1.51, a build with clang caused a warning with the <code>-Wunused-parameter</code> option. </p> <p> The latest change in 7b1b5aa452a9c7cc34230c99ac748a542cc23749 does not address the setter behavior, but removes the warning. </p> <p> The code should probably be: </p> <div class="wiki-code"><div class="code"><pre> <span class="kt">void</span> <span class="nf">delimiter_strings</span><span class="p">(</span><span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="n">separator</span><span class="p">,</span> <span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="n">start_delim</span><span class="p">,</span> <span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="n">open_end_delim</span><span class="p">,</span> <span class="k">const</span> <span class="n">string_type</span><span class="o">&amp;</span> <span class="n">closed_end_delim</span><span class="p">)</span> <span class="p">{</span> <span class="n">m_period_separator</span> <span class="o">=</span> <span class="n">separator</span><span class="p">;</span> <span class="n">m_period_start_delimeter</span> <span class="o">=</span> <span class="n">start_delim</span><span class="p">;</span> <span class="n">m_open_range_end_delimeter</span> <span class="o">=</span> <span class="n">open_end_delim</span><span class="p">;</span> <span class="n">m_closed_range_end_delimeter</span> <span class="o">=</span> <span class="n">closed_end_delim</span><span class="p">;</span> <span class="p">}</span> </pre></div></div> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/11142 Trac 1.4.3 James E. King, III Thu, 28 Dec 2017 14:09:36 GMT owner, status changed https://svn.boost.org/trac10/ticket/11142#comment:1 https://svn.boost.org/trac10/ticket/11142#comment:1 <ul> <li><strong>owner</strong> changed from <span class="trac-author">az_sw_dude</span> to <span class="trac-author">James E. King, III</span> </li> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">assigned</span> </li> </ul> Ticket James E. King, III Thu, 28 Dec 2017 17:03:44 GMT <link>https://svn.boost.org/trac10/ticket/11142#comment:2 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/11142#comment:2</guid> <description> <p> PR: <a class="ext-link" href="https://github.com/boostorg/date_time/pull/63"><span class="icon">​</span>https://github.com/boostorg/date_time/pull/63</a> </p> </description> <category>Ticket</category> </item> <item> <dc:creator>James E. King, III</dc:creator> <pubDate>Thu, 18 Jan 2018 13:45:59 GMT</pubDate> <title>milestone changed https://svn.boost.org/trac10/ticket/11142#comment:3 https://svn.boost.org/trac10/ticket/11142#comment:3 <ul> <li><strong>milestone</strong> <span class="trac-field-old">To Be Determined</span> → <span class="trac-field-new">Boost 1.67.0</span> </li> </ul> Ticket James E. King, III Sun, 28 Jan 2018 16:24:43 GMT status changed; resolution set https://svn.boost.org/trac10/ticket/11142#comment:4 https://svn.boost.org/trac10/ticket/11142#comment:4 <ul> <li><strong>status</strong> <span class="trac-field-old">assigned</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> Fix merged to master; resolved. </p> Ticket