Boost C++ Libraries: Ticket #11266: boost::packaged_task has invalid variadic signature

owner, status changed

viboes — Thu, 14 May 2015 15:53:42 GMT

owner changed from Anthony Williams to viboes
status new → assigned

Hi, you are surely right. I will take a look soon.

viboes — Thu, 14 May 2015 16:10:16 GMT

It seems that the last change is not really needed.

-        void operator()(BOOST_THREAD_RV_REF(ArgTypes)... args) {
+        void operator()(ArgTypes... args) {

Please, could you confirm?

Thu, 14 May 2015 17:29:38 GMT

It's needed. Just try slightly modified test:

#define BOOST_THREAD_VERSION 4
#include <boost/thread/future.hpp>
void func(int) { }
int main()
{
	boost::packaged_task<void(int)> task{func};
	task(0);	// ok
	int x = 0;
	task(x);	// compile error: can't bind to rvalue reference
}

milestone changed

viboes — Fri, 15 May 2015 13:38:08 GMT

milestone To Be Determined → Boost 1.59.0

Agreed and applied https://github.com/boostorg/thread/commit/aafd5ca7265e9edea1f100df88eb90c7653a70fc

milestone changed

viboes — Thu, 13 Aug 2015 06:59:28 GMT

milestone Boost 1.59.0 → Boost 1.60.0

status changed; resolution set

viboes — Wed, 02 Sep 2015 18:11:05 GMT

status assigned → closed
resolution → fixed

https://github.com/boostorg/thread/commit/a3497e1ffceb14318ff09e339a53293926351057