Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#11302 closed Bugs (fixed)

boost thread doesn't build with BOOST_THREAD_PATCH.

Reported by: pawels@… Owned by: viboes
Milestone: Boost 1.60.0 Component: thread
Version: Boost 1.58.0 Severity: Showstopper
Keywords: Cc:

Description

inside libs/thread/src/pthread/thread.cpp there's an access to currently private member 'epoch' in line 127:

if (current_thread_tls_init_flag.epoch!=BOOST_ONCE_INITIAL_FLAG_VALUE)

Attachments (1)

boost-tls.patch (1.0 KB ) - added by anonymous 7 years ago.
proposed patch.

Download all attachments as: .zip

Change History (16)

comment:1 by viboes, 7 years ago

Owner: changed from Anthony Williams to viboes
Status: newassigned

Well, this is not documented.

I tried long time ago to apply this patch but I didn't reached to get anything fixed. Please be free to propose a patch if you reach to make it work.

comment:2 by viboes, 7 years ago

Type: BugsSupport Requests

comment:3 by viboes, 7 years ago

Moved to support request as not documented.

by anonymous, 7 years ago

Attachment: boost-tls.patch added

proposed patch.

comment:4 by viboes, 7 years ago

Does this works for you? Does this definitively fix the dl issue?

comment:5 by viboes, 7 years ago

ping !!!

comment:6 by viboes, 7 years ago

ping !!!

comment:7 by anonymous, 7 years ago

yes, it works fine with testcase from ticket #3926.

Last edited 7 years ago by viboes (previous) (diff)

comment:8 by viboes, 7 years ago

Thanks. I will apply the patch very soon.

comment:9 by viboes, 7 years ago

I forget that I applied it already

https://github.com/boostorg/thread/commit/4d45da6c06970b54387ee040e20a8a88c84c50c0

Now I need to remove the conditional compilation on BOOST_THREAD_PATCH :(

comment:11 by viboes, 7 years ago

Milestone: To Be DeterminedBoost 1.60.0

comment:12 by viboes, 7 years ago

Type: Support RequestsBugs

comment:14 by blastrock, 7 years ago

It seems that this last patch was somehow reverted:

https://github.com/boostorg/thread/blob/develop/src/pthread/thread.cpp#L118

Any chance this gets fixed for boost 1.61?

comment:15 by blastrock, 7 years ago

Actually the code in boost 1.61 beta does not contain that #define check, and this is what triggers my bug. Forget what I just said, I will open a new ticket.

Note: See TracTickets for help on using tickets.