Boost C++ Libraries: Ticket #11330: boost::chrono::duration default constructor doesn't initialize rep_

status changed

viboes — Thu, 21 May 2015 20:42:50 GMT

status new → assigned

Hi,

you are right that there is an inconsistency I need to document.

The correct behavior is, following the standard, to don't initialize it. I received a request to be able to initialize it a zero.

I'm really sorry, but I would not initialize it in c++11. I could add a compiler flag to force the initialization.

#if  defined   BOOST_NO_CXX11_DEFAULTED_FUNCTIONS || \
     defined   BOOST_CHRONO_DURATION_DEFAULTS_TO_ZERO
        BOOST_FORCEINLINE BOOST_CONSTEXPR
        duration() : rep_(duration_values<rep>::zero()) { }
#else
        BOOST_CONSTEXPR duration() BOOST_NOEXCEPT {};
#endif

florent.castelli@… — Thu, 21 May 2015 21:07:00 GMT

I guess that's fair as long as it is documented as a breaking change and the documentation doesn't claim it is initialized.

I was thinking of possibly migrating the code to std::chrono so I'll have to make sure everything is properly initialized anyway. In the mean time, I guess having a local patch to initialize it to zero so I can migrate the rest of my code to 1.58.0 is fine.

viboes — Fri, 29 May 2015 17:56:42 GMT

So you agree for been forced to define BOOST_CHRONO_DURATION_DEFAULTS_TO_ZERO?

florent.castelli@… — Tue, 14 Jul 2015 15:01:26 GMT

Yes

florent.castelli@… — Tue, 14 Jul 2015 15:01:28 GMT

Yes

viboes — Mon, 03 Aug 2015 20:55:15 GMT

I was on vacation. I will do it asap.

milestone changed

viboes — Wed, 05 Aug 2015 17:35:21 GMT

milestone To Be Determined → Boost 1.60.0

https://github.com/boostorg/chrono/commit/6c7ff6678eea57e1e4e22c29ae9a7bfc023826ff

status changed; resolution set

viboes — Sun, 25 Oct 2015 23:53:59 GMT

status assigned → closed
resolution → fixed