Boost Test Exception Assert Failure has poor message

[merrill.cornish@…]

Here is the Boost Test assertion:

BOOST_CHECK_EXCEPTION(dummyOpr->setOperand(emptyValue), DiGSE::fail, fail_msg);

Here is the test execution log message:

info: check 'incorrect exception DiGSE::fail is caught' has passed

I have only one exception: DiGSE::fail (derived from std::exception). It is the /only /exception that appears in the BOOST_CHECK_EXCEPTION() assertions. So, what does "incorrect exception DiGSE::fail" mean? If DiGSE::fail was caught, then that part is correct. If the message means that some other exception was caught, then this is a Really Poor way of phrasing that information.

Or, did the predicate return false (which, in my case, means the exception message is wrong)?

But if the wrong exception was caught or the predicate returned false, then why was the assertion declared "has passed"?

[Gennadiy Rozental]

All messages on info level look weird.

You assertion has passed and Boost.Test just trying to notify you about this passed assertion. Part of the statement inside is just assertion description.

What message do you see if assertion fails? Does it make sense?

[Raffi Enficiaud]

Would you please test revision 4400d54b21533cd070048ffafc1865ce03468d4d (branch tractickets/11478-exception-poor-message). Now logs are printed like this:

../doc/examples/exception_check_predicate.run-fail.cpp:26: info: check 'exception \
   "my_exception" raised as expected: predicate "is_critical" validation on the raised \
   exception' has passed                                                 

or

../doc/examples/exception_api.run-fail.cpp:54: info: check 'exception std::exception \
   raised as expected' has passed

If you have a better/clearer phrasing, please let me know.

[Raffi Enficiaud]

merged to master