Boost C++ Libraries: Ticket #11520: pointer_iserializer requires operator delete(void*, size_t) for classes that have a specific operator new

status changed; resolution set

Robert Ramey — Mon, 28 Sep 2015 06:05:24 GMT

status new → closed
resolution → fixed

OK - I find you're argument pretty convincing so I'll check the change into the development branch.

I'm wondering why the two argument version exists at all.

status changed; resolution deleted

Robert Ramey — Mon, 28 Sep 2015 07:15:15 GMT

status closed → reopened
resolution fixed

Damn!

I made the change and it failed to compile test_new_operator.

So, I'm back to seeing how to figure which operator arguments to call.

I notice I made the change 18 months ago and this is the first complaint. i'm not sure what else to do here. There is a way to figure out which function exists - but it's would be pretty complex to implement. If you want to do it (and improve the test) I'll consider adding it in. Google boost check if function exists

Robert Ramey — Mon, 28 Sep 2015 22:18:26 GMT

OK - I looked at this some more - I believe the right solution is to use SFINAE to detect which functions are implemented and call the correct one.

Unfortunately, this is kind of a pain so it will be some time before I get to it.

Feel free to submit a patch

Robert Ramey — Mon, 05 Oct 2015 16:20:14 GMT

"I don't know how to test which of the two operators exists, but it seems safer to me to use the one-argument version. My existing code stopped working after upgrading boost, and I do not have access to the class being serialized. I am using an external non-intrusive serialization function."

OK - I "fixed" this in that it automatically select the one vs two argument version. However it fails to detect and case where the class has no member function operator delete. So it fixes your problem but leaves one case unfixed. I spend a fair amount of time on this and wasn't able to find a clean way of doing this. I'm sure some smart guy can do it but for now I'm going to declare victory and close this ticket.

I also updated the test in order to verify this.

status changed; resolution set

Robert Ramey — Wed, 07 Oct 2015 19:17:02 GMT

status reopened → closed
resolution → fixed

attachment set

fabian.kislat@… — Wed, 20 Jan 2016 18:24:45 GMT

attachment → choose_deleter.cpp

Example, how one might handle all three cases: delete operator with one or two arguments, or no class specific delete at all using SFINAE

kartikmohta@… — Sun, 06 Mar 2016 08:03:41 GMT

This also fails in the case when a class has both the operators defined. A simple example:

#include <boost/archive/text_iarchive.hpp>
#include <boost/serialization/export.hpp>
class TestClass
{
 public:
  void* operator new(size_t size) { return ::operator new(size); }
  void operator delete(void * ptr) { return ::operator delete(ptr); }
  void operator delete(void *ptr, size_t /*size*/) { return ::operator delete(ptr); }
  template <class Archive>
  void serialize(Archive & /* ar */, const unsigned int /* version */)
  {
  }
};
BOOST_CLASS_EXPORT_IMPLEMENT(TestClass);
int main()
{
  return 0;
}

Don't have a solution for this, but just making a note here in case someone can solve the issue.

status changed; resolution deleted

kartikmohta@… — Sun, 06 Mar 2016 08:04:42 GMT

status closed → reopened
resolution fixed