Boost C++ Libraries: Ticket #11657: Add VxWorks support for program options

attachment set

Wed, 16 Sep 2015 05:14:04 GMT

attachment → vx_program_options.patch

type changed

Wed, 16 Sep 2015 05:24:29 GMT

type Bugs → Patches

Vladimir Prus — Wed, 16 Sep 2015 05:34:24 GMT

Am I right that this patch can be applied without waiting for the config one?

Wed, 16 Sep 2015 05:36:03 GMT

Yes, no interdependence.

Vladimir Prus — Wed, 16 Sep 2015 06:40:13 GMT

Good. Why did you need to define environ as const char and then cast to 'char '? At the very least, the cast should be const_cast, not a C-style cast, but I wonder whether it can be declare as non-const in the first place? Or environment on VxWorks is not writable?

Fri, 18 Sep 2015 17:00:07 GMT

It's effectively read only on every platform, you manipulate though setenv() POSIX says make it http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap08.html

But a decade ago when the VxWorks implementation was done, the engineer didn't read the spec. Maybe it's time to change it, our rule of thumb here at Wind is POSIX compatibility before backward compatibility in user space and vise versa in the kernel.

I'll file a defect on my side you can ignor this patch.