Boost C++ Libraries: Ticket #11802: Incorrect ordering after using insert() with ordered_range_t on a flat_multiset with a non-default sort order

attachment set

mm-info@… — Wed, 18 Nov 2015 11:04:06 GMT

attachment → test.cc

mm-info@… — Wed, 18 Nov 2015 12:41:24 GMT

Version 1.58 works as expected.

Thu, 19 Nov 2015 10:39:34 GMT

Clarification: My example is using flat_multiset although the title states flat_set. (I haven't actually tried anything but flat_multiset.)

summary changed

viboes — Sun, 06 Dec 2015 08:59:34 GMT

summary Incorrect ordering after using insert() with ordered_range_t on a flat_set with a non-default sort order → Incorrect ordering after using insert() with ordered_range_t on a flat_multiset with a non-default sort order

Ion Gaztañaga — Thu, 24 Dec 2015 00:28:47 GMT

The error should be fixed in recently released Boost 1.60, in my tests your example passes fine. Could you please check if that's the problem is fixed for you?

Thu, 31 Dec 2015 12:50:43 GMT

I cannot confirm this fixes it for me. Neither in my primary use or in the example provided. Maybe it's compiler related. I'm on OS X:

> clang++ -std=c++11 -I/path/to/boost_1_60_0/ test.cc && ./a.out
Assertion failed: (*values.begin() == 1), function main, file test.cc, line 15.
> clang --version
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.2.0
Thread model: posix

As previously noted it works with 1.58. It fails with both 1.59 and 1.60.

Sat, 02 Jan 2016 11:18:29 GMT

In case this helps, I can make it work by reverting flat_tree.hpp to the version used in 1.58. The main difference appears to be that ordered insertion is now handled by merge_unique in the vector class. I took a quick look at that and was a bit worried about this comment for a subfunction:

 //Absolutely experimental. This function might change, disappear or simply crash!

status changed; resolution set

Ion Gaztañaga — Thu, 11 Aug 2016 22:45:25 GMT

status new → closed
resolution → fixed

Reviewing old bugs that were forgotten. The error was reproduced and the following commit fixes it:

https://github.com/boostorg/container/commit/d5adae2edadbb43f78dcfcb21bd4792a8876f6f0

Many thanks for your report and patience.

mm-info@… — Fri, 12 Aug 2016 08:37:42 GMT

Awesome! Thanks.