Boost C++ Libraries: Ticket #11803: Fails with closed intervals fails in some border cases.

attachment set

shewitt.au@… — Wed, 18 Nov 2015 17:03:35 GMT

attachment → icl_question.cpp

shewitt.au@… — Wed, 18 Nov 2015 17:11:36 GMT

Here's the output of the sample program:

BAD:  {[0,9fff][a000,ffff]}
GOOD: {[0,9fff][a000,bfff][c000,fffe]}

anonymous — Wed, 18 Nov 2015 22:49:05 GMT

Correction: The comment for left_subtract is correct and should read as is ("The part of \c right right of \c left_minuend."). It's the comment for right_subtract that's wrong. It reads "Return the difference: The part of \c left right of \c right_minuend." the word in boldshould read "left".

Clarification: The extra check I added is already present in right_subtract so efficiency arguments seem not to apply.

anonymous — Thu, 19 Nov 2015 00:22:47 GMT

It's been mention in mailing list that "You can use icl interval containers with limited integral numeric domain-types safely on intervals using values from ++std::min<T>() to--std::max<T>()".

If this is the case then even code such as this is illegal:

boost::interval_set<unsigned int> int(0, 10);

This seems unacceptable. And as mentioned above the code in right_subtract already guards against this.

status changed; resolution set

Joachim Faulhaber — Thu, 19 Nov 2015 08:56:12 GMT

status new → closed
resolution → fixed

shewitt.au@… — Thu, 19 Nov 2015 12:18:22 GMT

Replying to jofaber: I'm new to the boost svn repo and such, but I can't see any changes. The obvious question is does "Resolution set to fixed" mean changes were made to fix this issue, or, that no changes were made because this it is not considered a problem?

Joachim Faulhaber — Thu, 19 Nov 2015 12:51:10 GMT

Replying to shewitt.au@…:

Replying to jofaber: I'm new to the boost svn repo and such, but I can't see any changes. The obvious question is does "Resolution set to fixed" mean changes were made to fix this issue, or, that no changes were made because this it is not considered a problem?

The changes were made to the develop branch on modular-boost https://github.com/boostorg/icl/blob/develop/include/boost/icl/concept/interval.hpp

From there it will be merged to master after regression tests are being checked.