Boost C++ Libraries: Ticket #11864: C4348 - Multiple warnings in Boost::Spirit

Wed, 23 Dec 2015 02:38:00 GMT

When compiling using Boost 1.60 in MSVC 2010 I get the following 2 warnings which I never had before when using Boost 1.58 and is really annoying.

============================================================================ 3>\boost/spirit/home/support/terminal.hpp(264): warning C4348: 'boost::spirit::terminal<Terminal>::result_helper' : redefinition of default parameter : parameter 3 3> with 3> [ 3> Terminal=boost::spirit::tag::lit 3> ] 3> boost/spirit/home/support/terminal.hpp(270) : see declaration of 'boost::spirit::terminal<Terminal>::result_helper' 3> with 3> [ 3> Terminal=boost::spirit::tag::lit 3> ] ============================================================================

============================================================================ 3>\boost/spirit/home/support/terminal.hpp(264): warning C4348: 'boost::spirit::terminal<Terminal>::result_helper' : redefinition of default parameter : parameter 4 3> with 3> [ 3> Terminal=boost::spirit::tag::ulong_ 3> ] 3> \boost/spirit/home/support/terminal.hpp(270) : see declaration of 'boost::spirit::terminal<Terminal>::result_helper' 3> with 3> [ 3> Terminal=boost::spirit::tag::ulong_ 3> ] 3> \boost/spirit/home/support/common_terminals.hpp(142) : see reference to class template instantiation 'boost::spirit::terminal<Terminal>' being compiled 3> with 3> [ 3> Terminal=boost::spirit::tag::ulong_ 3> ] ============================================================================

Joel de Guzman — Wed, 23 Dec 2015 02:46:02 GMT

Can you please submit a patch to https://github.com/boostorg/spirit/ develop branch?

cc set

Wed, 10 Feb 2016 16:08:39 GMT

cc braden@… added

cc set

Wed, 10 Feb 2016 16:08:41 GMT

cc braden@… added

cc set

Wed, 10 Feb 2016 16:08:43 GMT

cc braden@… added

cc set

Wed, 10 Feb 2016 16:08:43 GMT

cc braden@… added

cc set

Wed, 10 Feb 2016 16:08:44 GMT

cc braden@… added

cc set

Wed, 10 Feb 2016 16:08:45 GMT

cc braden@… added

Wed, 10 Feb 2016 16:44:35 GMT

This looks like it was fixed here: https://github.com/boostorg/spirit/commit/a6c79bc35c55033b7a31ca2d66abe241695b4717

status changed; resolution set

Joel de Guzman — Mon, 18 Dec 2017 23:22:41 GMT

status new → closed
resolution → fixed