Boost C++ Libraries: Ticket #11888: boost.test throws an exception when passed a custom command line parameter

Raffi Enficiaud — Sat, 09 Jan 2016 14:39:22 GMT

I believe you meant when you upgraded from 1.59 to 1.60, please confirm.

The API for command line has changed in 1.60, and -- needs to be added before user command line arguments, as explained eg. here http://www.boost.org/doc/libs/master/libs/test/doc/html/boost_test/change_log.html.

If you are using a test driver such as cmake, this can be easily achieved by testing against the version of boost.

Sat, 09 Jan 2016 17:38:47 GMT

Ah ok, I just realised I didn't look at the 1.60 documentation. I skipped version 1.59 on windows when trying this upgrade as it was the latest version. I must have only looked at the 1.59 documentation though. I had to fix up some breaking api changes and someone had already fixed up similar errors when changing our linux builds over to version 1.59 so I wrongly assumed everything had changed in that version.

Is there a more detailed version of the changes between these version? I couldn't find mention of some of the changes in the documentation for either version. Off the top of my head some of the changes were the methods of test reporter changed and the way of querying the runtime config.

Raffi Enficiaud — Sun, 10 Jan 2016 15:28:12 GMT

There is the changelog that you may find here, that summarizes as accurately as possible the changes between versions:

http://www.boost.org/doc/libs/master/libs/test/doc/html/boost_test/change_log.html

but maybe this deserves some more entry in the "runtime parameter configuration":

http://www.boost.org/doc/libs/master/libs/test/doc/html/boost_test/runtime_config.html

What do you think would make the information more accessible?

owner, status changed

Raffi Enficiaud — Sun, 10 Jan 2016 15:28:28 GMT

owner changed from Gennadiy Rozental to Raffi Enficiaud
status new → assigned

version changed

Raffi Enficiaud — Mon, 11 Jan 2016 14:25:27 GMT

version Boost 1.59.0 → Boost 1.60.0

Mon, 11 Jan 2016 15:37:33 GMT

I think having the api in changes in change_log.html is the best place for them. I would have liked to know:

the call to boost::unit_test::runtime_config::log_format() was replaced with a generic template system boost::unit_test::runtime_config::get<boost::unit_test::output_format>( boost::unit_test::runtime_config::OUTPUT_FORMAT), this could then link to the runtime_config.html page with a more detailed explanation
The enum for format types was renamed boost::unit_test::XML was renamed to boost::unit_test::OF_XML etc.
boost::unit_test::unit_test_log_formatter::test_unit_skipped() now takes a const_string reason.
boost::unit_test::unit_test_log_formatter::log_exception() was replaced with log_exception_start and log_exception_finish
boost::unit_test::unit_test_log_formatter has new functions added for contexts: entry_context_start(), log_entry_context() and entry_context_finish()

If all that was available from the change_log.html then there would be less digging around in the source to see what was required to fix up. If any of these were marked as internal to boost test then I understand it's up to me to fix them but if they are in the public api then it would be good to have some mention of the changes.

I guess doing a diff with the last released version would get you a good idea of what should be mentioned.

severity changed

Raffi Enficiaud — Wed, 13 Jan 2016 22:45:50 GMT

severity Showstopper → Problem

status changed; resolution set

Raffi Enficiaud — Sun, 11 Dec 2016 19:07:31 GMT

status assigned → closed
resolution → wontfix

All those have been documented in 1.62 (api documentation). I believe modifying the change_log now would not improve this. Also there were so many changes between 1.58 and 1.59...