Boost C++ Libraries: Ticket #11889: BOOST_DATA_TEST_CASE fails to compile for 4D and higher dimensional grids

attachment set

Wed, 06 Jan 2016 13:35:40 GMT

attachment → reproduction.zip

Source and CMake file to reproduce error

attachment set

Wed, 06 Jan 2016 13:35:49 GMT

attachment → reproduction.2.zip

Source and CMake file to reproduce error

Wed, 06 Jan 2016 13:38:14 GMT

The second attachment (reproduction.2.zip) can be ignored. Due to reloading the first got uploaded twice. I apologize for the inconvenience.

Raffi Enficiaud — Sat, 09 Jan 2016 14:36:24 GMT

You're correct, this piece of information is missing in the documentation. This fix is ready on the branch topic/data-variadic-template of boost.test. Can you please give a try?

Sat, 09 Jan 2016 16:15:34 GMT

I tried to set up modular boost and compile with that. The error message changed to

/tmp/modular-boost/boost/test/data/for_each_sample.hpp:52:11:
error: no match for call to
'(const boost::unit_test::data::ds_detail::test_case_gen<
    Test_4D_grid, boost::unit_test::data::monomorphic::grid<
        boost::unit_test::data::monomorphic::grid<
            boost::unit_test::data::monomorphic::grid<
                boost::unit_test::data::monomorphic::generated_by<
                    boost::unit_test::data::monomorphic::xrange_t<int, int>
                >,
                boost::unit_test::data::monomorphic::generated_by<
                    boost::unit_test::data::monomorphic::xrange_t<int, int>
                >
            >,
            boost::unit_test::data::monomorphic::generated_by<
                boost::unit_test::data::monomorphic::xrange_t<int, int>
            >
        >,
        boost::unit_test::data::monomorphic::generated_by<
            boost::unit_test::data::monomorphic::xrange_t<int, int>
        >
    >
>)
(const int&, const int&, const int&, const int&)'
     action( std::get<I>(args)... );
/tmp/modular-boost/boost/test/data/test_case.hpp:100:13:
note: candidate:
template<class Arg0> void boost::unit_test::data::ds_detail::test_case_gen<TestCase, DataSet>::operator()(const Arg0&) const [with Arg0 = Arg0; TestCase = Test_4D_grid; DataSet = boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >]
     void    operator()( BOOST_PP_ENUM_BINARY_PARAMS(arity, Arg, const& arg) ) const \
in expansion of macro ...
/tmp/modular-boost/boost/test/data/test_case.hpp:107:5: note: in expansion of macro 'BOOST_PP_REPEAT_FROM_TO'
     BOOST_PP_REPEAT_FROM_TO(1, 4, TC_MAKE, _)
     ^
/tmp/modular-boost/boost/test/data/for_each_sample.hpp:52:11:
note:   candidate expects 1 argument, 4 provided
     action( std::get<I>(args)... );
/tmp/modular-boost/boost/test/data/test_case.hpp:100:13:
note: candidate:
template<class Arg0, class Arg1> void boost::unit_test::data::ds_detail::test_case_gen<TestCase, DataSet>::operator()(const Arg0&, const Arg1&) const [with Arg0 = Arg0; Arg1 = Arg1; TestCase = Test_4D_grid; DataSet = boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >]
     void    operator()( BOOST_PP_ENUM_BINARY_PARAMS(arity, Arg, const& arg) ) const \
in expansion of macro ...
/tmp/modular-boost/boost/test/data/test_case.hpp:107:5: note: in expansion of macro 'BOOST_PP_REPEAT_FROM_TO'
     BOOST_PP_REPEAT_FROM_TO(1, 4, TC_MAKE, _)
     ^
tmp/modular-boost/boost/test/data/for_each_sample.hpp:52:11: note:   candidate expects 2 arguments, 4 provided
     action( std::get<I>(args)... );
/tmp/modular-boost/boost/test/data/test_case.hpp:100:13:
note: candidate:
template<class Arg0, class Arg1, class Arg2> void boost::unit_test::data::ds_detail::test_case_gen<TestCase, DataSet>::operator()(const Arg0&, const Arg1&, const Arg2&) const [with Arg0 = Arg0; Arg1 = Arg1; Arg2 = Arg2; TestCase = Test_4D_grid; DataSet = boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::grid<boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >, boost::unit_test::data::monomorphic::generated_by<boost::unit_test::data::monomorphic::xrange_t<int, int> > >]
     void    operator()( BOOST_PP_ENUM_BINARY_PARAMS(arity, Arg, const& arg) ) const \
/tmp/modular-boost/boost/test/data/test_case.hpp:107:5: note: in expansion of macro 'BOOST_PP_REPEAT_FROM_TO'
     BOOST_PP_REPEAT_FROM_TO(1, 4, TC_MAKE, _)
     ^
/tmp/modular-boost/boost/test/data/for_each_sample.hpp:52:11: note:   candidate expects 3 arguments, 4 provided
     action( std::get<I>(args)... );

when compiling the code in the reproduction.zip

Raffi Enficiaud — Sat, 09 Jan 2016 16:21:19 GMT

Thank you for your quick feedback, I will have a look into it. As a side note: this feature request was planned but as you may see it is not mature enough.

Raffi Enficiaud — Sat, 09 Jan 2016 17:28:58 GMT

I just pushed a change to this branch, would you please try again?

Sat, 09 Jan 2016 18:43:16 GMT

That one compiles. However, I cannot link for now (would have to build boost first), so there are no runtime results from my side yet.

Btw. can't you test the code from reproduction.zip on your machine or did it already work?

Raffi Enficiaud — Sat, 09 Jan 2016 19:50:15 GMT

I created a similar test case in boost.test already (in the branch), and as for your specific example, you should not have any link issue since you are using the header only variant.

Raffi Enficiaud — Sat, 09 Jan 2016 19:51:28 GMT

The documentation entry for building boost.test, just in case:

http://www.boost.org/doc/libs/master/libs/test/doc/html/boost_test/adv_scenarios/build_utf.html

Sun, 10 Jan 2016 09:23:31 GMT

I created a similar test case in boost.test already (in the branch),

So your tests passed but mine didn't?

you should not have any link issue since you are using the header only variant

Yes, I wondered too, but now it is clear that I forgot #define BOOST_TEST_MODULE. After adding that, I got no more linker errors and the tests seem to run correctly.

Raffi Enficiaud — Sun, 10 Jan 2016 11:39:14 GMT

Perfect, this should be available for the next release.

owner changed

Raffi Enficiaud — Sun, 10 Jan 2016 11:39:53 GMT

owner changed from Gennadiy Rozental to Raffi Enficiaud

status changed

Raffi Enficiaud — Sun, 10 Jan 2016 15:29:15 GMT

status new → assigned

milestone changed

Raffi Enficiaud — Tue, 12 Jan 2016 08:36:00 GMT

milestone To Be Determined → Boost 1.61.0

status changed; resolution set

Raffi Enficiaud — Tue, 02 Feb 2016 08:23:15 GMT

status assigned → closed
resolution → fixed

Commits:

8ed17b554df2eaf9dfa4849012dc19e150d4c23c
673c7aeb3932d67972659002b38b256d6cc4bdb3
673c7aeb3932d67972659002b38b256d6cc4bdb3
42de00192e0a2f1571d9025bf2207bf19540fe6f

Merged in master: 2b918d0bd56cd2add28a1e35c6a2d0fd8c60cf90