Boost C++ Libraries: Ticket #12141: XML serialization broken

Robert Ramey — Wed, 20 Apr 2016 18:30:43 GMT

what compiler, platform, etc. can reproduce this?

Wed, 20 Apr 2016 19:41:51 GMT

I'm seeing this on both:

g++ (Ubuntu 5.2.1-22ubuntu2) 5.2.1 20151010
GNU libstdc++ version 20151010

...and:

Ubuntu clang version 3.6.2-1 (tags/RELEASE_362/final) (based on LLVM 3.6.2)
libc++ version 1101

Both are running on:

Ubuntu 15.10
Linux 4.2.0-35-generic #40-Ubuntu SMP Tue Mar 15 22:15:45 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

status changed; resolution set

Robert Ramey — Thu, 21 Apr 2016 22:14:08 GMT

status new → closed
resolution → fixed

Wow - my tests didn't detect this. I've made the change and tested on my own system and uploaded it to boost. Early tomorrow I'll ask permission to merge into master so it can be included in to the official release of 1.61. I don't know if they'll accept it though.

anonymous — Fri, 22 Apr 2016 08:41:09 GMT

Great stuff. Thanks very much for addressing this so quickly. Yes - definitely worth getting this test case into the suite.

I think this has got to be a good candidate for them allowing a merge because I'd estimate the cost of keeping this error in would easily outweigh the expected cost of possible problems caused by the change.

Thanks again.

mark.incley@… — Thu, 01 Sep 2016 13:26:04 GMT

Hi. Using Boost 1.62 Beta 1 and Visual Studio 2015 Update 3, I'm still seeing the exact same issue reported by Colin here: http://lists.boost.org/boost-users/2016/06/86317.php

i.e. the xml file ending with:

</boost_serialization>
&lt;/boost_serialization&gt;

status changed; resolution deleted

anonymous — Mon, 26 Sep 2016 08:57:42 GMT

status closed → reopened
resolution fixed

mark.incley@… — Mon, 26 Sep 2016 09:34:52 GMT

The problem still in Boost 1.62 Beta 1 (and Beta 2) only occurs with the wide XML archiver (xml_woarchive) and not the narrow one (xml_oarchive), and seems to be due to the difference in behaviour (other than char types) between:

xml_oarchive_impl<Archive>::save(const char * s)

and

xml_woarchive_impl<Archive>::save(const wchar_t * ws)

Mark.

attachment set

frank.richter@… — Thu, 03 Aug 2017 07:44:03 GMT

attachment → xml_woarchive_impl.diff

Patch to fix xml_woarchive writing after last tag

frank.richter@… — Thu, 03 Aug 2017 07:44:34 GMT

Attached patch fixes it for me.

Wed, 08 Nov 2017 16:40:52 GMT

Is this still open or been fixed? I'm using boost 1.65 and I'm getting an extra closing tag of </boost_serialization> at the end of the file. It only does this for xml_woarchive, the narrow archive is fine.

Brian