Boost C++ Libraries: Ticket #12233: boost::regex doesn't compile with clang on windows

juandent@… — Sat, 28 May 2016 21:14:49 GMT

Hi, I also find unresolved external symbols when I try to link with Boost when compiling with Clang 3.7 with Microsoft CodeGen. Couldn't it be that the Boost libraries were built with the usual Microsoft instead of clang?

Or did you build your Boost libraries with Clang 3.7? If so, can you explain me how? Did you create a VStudio 2015 Update 2 solution to build Boost? Where did you get such solution? If you used CMake to generate VStudio projects, where did you get the CMAkeLists.txt files?

I hope we can find the solution to this together!

Regards, Juan

juandent@… — Sat, 28 May 2016 21:14:55 GMT

I hope we can find the solution to this together!

Regards, Juan

juandent@… — Sat, 28 May 2016 21:15:03 GMT

I hope we can find the solution to this together!

Regards, Juan

Sun, 29 May 2016 06:29:20 GMT

I used the precompiled VC14 binaries with clang 3.9 from trunk. Building boost clang is really a different topic because I think it's currently unsupported. Though clang has full VC++ ABI compatibility which should work in this case too.

All but this one symbol is missing:

public: bool __cdecl boost::re_detail_106100::abstract_protected_call::execute(void)const

John Maddock — Mon, 30 May 2016 07:31:03 GMT

I'm not sure this is ever going to work - you would need to build regex with clang as well.

Note that the regex source is "just a bunch of source files", you can build the source in libs/regex/src/*.cpp using whatever method you wish.

anonymous — Mon, 30 May 2016 07:43:57 GMT

Replying to johnmaddock:

I'm not sure this is ever going to work - you would need to build regex with clang as well.

Note that the regex source is "just a bunch of source files", you can build the source in libs/regex/src/*.cpp using whatever method you wish.

Just to be on the same page I don't claim this to be a boost bug, I am just trying to understand how is the boost::re_detail_106100::abstract_protected_call::execute symbol is special since clang can't find it. Any tips for me before I look at the source code?

Thanks!

Mon, 30 May 2016 11:04:15 GMT

This works when compiling everything with clang so it's surely a bug in clang's MSVC compat. Please feel free to close this bug, I'll be reporting a clang bug when I find the problem.

John Maddock — Mon, 30 May 2016 11:52:58 GMT

Not necessarily a clang bug - I suspect we don't have MSVC and clang configured in exactly the same way - for that matter I'm not sure we would want to (as it would mean disabling clang features), but unless the two compilers are identically configured in Boost.Config etc you won't get binary-compatible objects.

Mon, 30 May 2016 11:56:59 GMT

clang-cl.exe is supposed to be a drop in replacement for cl.exe including binary compatibility. Any difference is a bug. I will update this bug after reporting the relevant clang bug.

John Maddock — Mon, 30 May 2016 12:39:41 GMT

You're missing the point: we don't configure clang and msvc the same so the libraries won't contain the same symbols.

Mon, 30 May 2016 12:41:49 GMT

Then as I currently suspect boost "needs" something like BOOST_CLANG_CL akin to BOOST_MSVC which enables clang features + MSVC features supported.

adamf88@… — Wed, 19 Oct 2016 21:23:19 GMT

Hi eceryone,

I found the same issue. I have boost compiled with MSVC toolset (2010) and I'm trying to link it to project with clang toolset. I have no problems with libraries like boost::filesystem. The regexp is the first one I found problem.

I had some time (it took a while) to debug it, but finally I found the reason (if you want to read it in a nutshell then scroll down to point 5):

The error message says than abstract_protected_call::execute() is missing from regex.cpp in the library. I checked the generated libboost_regex-vc100-mt-gd-1_62.lib file. This is true, this function is missing. But why MSVC compilation works and Clang doesn't ?
To answer the question we have to look around. This function is guarded by define: BOOST_REGEX_HAS_MS_STACK_GUARD. If we get the things together then: on MSVC toolset BOOST_REGEX_HAS_MS_STACK_GUARD is undefined (because in lib is missing) and on clang the symbol is defined (because it looks for this function). Let's check it
The symbol is defined in file regex\config.hxx. (line 370 in boost 1.62.0). For tests I added pragma line above this definition: #pragma message("TEST") then we will get this message on clang build and during regex compilation with MSVC. (So the function execute should be available because the symbol is defined), but:
In line 417 in file config.hpp we can find:

#  ifdef BOOST_REGEX_HAS_MS_STACK_GUARD
#     undef BOOST_REGEX_HAS_MS_STACK_GUARD
#  endif

Lets add #pragma message ("UNDEFINED") and check when it is executed. Finally: MSVC compilation boost::regexp library - we will get message UNDEFINED. So the symbol is undefined and our method is not available in static lib. Clang (test project compilation with regexp) - no message. So symbol BOOST_REGEX_HAS_MS_STACK_GUARD is still defined and clang tries to link this function (execute).

Where is the difference ?

In line 395 (regex/config.hpp) we can find define with statement (this statement enables undef code block execution):

!(defined(BOOST_MSVC) && (BOOST_MSVC >= 1400)

If we build sample project with Clang toolset then BOOST_MSVC is undefined. And it is the reason why the compilation fails. Why this symbol is undefined ? Clang should pretend to be MSVC perfectly ( really ? :) ). To answer this last question we should look into file: "config/select_compiler_config.hpp". Clang on windows defines symbols: clang and _MSC_VER, but the check for clang is before check for MSVC and clang toolset was selected. So boost doesn't define BOOST_MSVC for clang toolset compilation.

Unfortunately clang doesn't pretend to be MSVC perfectly and it caused the error. I hope it will help you to do the fix.

My quick and dirty fix was in select_compiler_config.hpp file by adding on the end of clang toolset checking: && !defined(_MSC_VER). But I didn't run any other tests and I don't know if it doesn't cause any other issues. ( My program now works :) )

Dear boost support: Will you do any fix of this issue in the next versions of boost library ? Do you have any plans to support boost build with clang toolset on windows ?

Regards, Adam

status, milestone changed; resolution set

John Maddock — Wed, 08 Feb 2017 19:38:15 GMT

status new → closed
resolution → fixed
milestone To Be Determined → Boost 1.64.0

I believe this is now fixed in https://github.com/boostorg/regex/commit/4bfdae4a9f7ca8b74dba4da3ba09d376d260e19f