id,summary,reporter,owner,description,type,status,milestone,component,version,severity,resolution,keywords,cc
12354,boost::asio::connect crash when connect_condition sets iterator to end,snua12@…,chris_kohlhoff,"example:

{{{


auto getIPV4Only = [](const error_code& ec, iterator next) {
	resolver::iterator end;
	while (!ec && next != end) {
		if (next->endpoint().address().is_v4()) return next;
		++next;
	}
	return next;
};

connect(socket, iterator, getIPV4Only, ec); //<- crashes when getIPV4Only returns end
}}}


fix:

{{{

--- include/boost/asio/impl/connect.hpp (revision 1.6.0)
+++ include/boost/asio/impl/connect.hpp (working copy)
@@ -122,7 +122,9 @@
       s.connect(*iter, ec);
       if (!ec)
         return iter;
-    }
+       } else {
+               break;
+       }
   }

   if (!ec)


}}}
",Bugs,new,To Be Determined,asio,Boost 1.60.0,Problem,,,