Changes between Initial Version and Version 1 of Ticket #12362


Ignore:
Timestamp:
Jul 29, 2016, 11:13:22 PM (6 years ago)
Author:
Emil Dotchevski
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12362

    • Property Status new → closed
    • Property Resolution → invalid

  • Ticket #12362 – Description

    initial v1  
    1 In exception_ptr.hpp lines 322 to 325:
    2 
    3 {{{
    4                 default:
    5                     BOOST_ASSERT(0);
    6                 case exception_detail::clone_current_exception_result::
    7                 not_supported:
    8 }}}
    9 
    10 Coverity complains about the fall-through.
    11 Changing it to the following will resolve this and make intentions clearer:
    12 
    13 {{{
    14                 default:
    15                     BOOST_ASSERT(0);
    16                     // fall through
    17                 case exception_detail::clone_current_exception_result::
    18                 not_supported:
    19 }}}
    20 
    21 This is present in the development trunk and goes back to at least 1.54.
     1This is not fall through but undefined behavior as indicated by the use of BOOST_ASSERT. Adding the fall through comment is incorrect and would be misleading.