cppljevans@… — Wed, 10 Aug 2016 19:24:19 GMT

Replying to cppljevans@…:

The purpose of creating of a static variable here:

https://github.com/boostorg/spirit/blob/develop/include/boost/spirit/home/x3/nonterminal/rule.hpp#L164

is not apparent. Why wouldn't the following replacement:

auto const& def_=BOOST_PP_CAT(rule_name, _def);

work just as well. If not, some source code comments explaining the need for creating a new instance of a struct would help maintainers and people trying to understand the code.

Closer inspection of rule_definition shows it handles attributes. Sorry for noise. Please ignore this ticket.

component changed; owner set

viboes — Fri, 19 Aug 2016 21:18:15 GMT

owner set to Joel de Guzman
component None → spirit

status changed; resolution set

Joel de Guzman — Mon, 18 Dec 2017 23:25:03 GMT

status new → closed
resolution → fixed

Boost C++ Libraries: Ticket #12388: useless static const generated by BOOST_SPIRIT_DEFINE_?

component changed; owner set

status changed; resolution set