Boost C++ Libraries: Ticket #12438: Wrong additional closing tag in boost::archive::xml_woarchive

Robert Ramey — Tue, 01 Nov 2016 22:10:57 GMT

this is clearly an error. I thought I fixed this in the final release of 1.61. Are you sure that you're not using one of pre-release betas? Does the issue still show up in the develop branch?

anonymous — Wed, 02 Nov 2016 19:12:33 GMT

The reported error is Boost 1.62 release (when I reported the error Boost 1.62 beta was in use).

Robert Ramey — Wed, 02 Nov 2016 19:24:13 GMT

Did you upgrade to the 1.62 final? The log shows that a fix was checked into the master (32b2bda) on April 21,2016. Is this fix not in your code? or does the "fix" fail to address the issue?

anonymous — Fri, 04 Nov 2016 16:22:29 GMT

The latest 1.62 release we upgraded to is the final one, it is not a beta. We loaded it from https://sourceforge.net/projects/boost/files/boost-binaries/1.62.0/boost_1_62_0-bin-msvc-all-32-64.7z/download The timestamp is 2016-09-26. It has not been updated since then.

status changed; resolution set

Robert Ramey — Wed, 03 May 2017 22:32:36 GMT

status new → closed
resolution → fixed

I've just tested this on my version on the develop branch and it IS fixed there.

I recently realized that due to an oversight on my part, some fixes on my local develop branch weren't merged and pushed. But I think that's fixed now. Unfortunately, this isn't in the latest release but it should be in the next one for sure.

Robert Ramey

jaroslav.beran@… — Wed, 05 Jul 2017 17:42:15 GMT

I found same bug in version 1.62. I tried to use version 1.64 (downloaded from https://dl.bintray.com/boostorg/release/1.64.0/source/boost_1_64_0.7z) with same result (additional line).

I've modified the file .\boost_1_64_0\boost\archive\impl\xml_woarchive_impl.ipp as shown below and it works fine for me now.

#ifndef BOOST_NO_INTRINSIC_WCHAR_T
template<class Archive>
BOOST_WARCHIVE_DECL void
xml_woarchive_impl<Archive>::save(const wchar_t * ws){

os << ws;

/* next lines commented out to fix #12438 Wrong additional closing tag in boost::archive::xml_woarchive */
#if 0

typedef iterators::xml_escape<const wchar_t *> xmbtows;
std::copy(

xmbtows(ws),
xmbtows(ws + std::wcslen(ws)),
boost::archive::iterators::ostream_iterator<wchar_t>(os)

);

#endif
}

#endif