Boost C++ Libraries: Ticket #12604: neither scoped_array nor checked_delete do check for nullptr

attachment set

anonymous — Fri, 11 Nov 2016 10:17:46 GMT

attachment → test.cpp

Peter Dimov — Fri, 11 Nov 2016 11:09:06 GMT

nullptr is a valid argument for checked_delete, which basically calls delete. Your test case works for me.

anonymous — Fri, 11 Nov 2016 12:24:53 GMT

I am lost ... on every machine I tried, the attached code throws a segfault.

$ ./test
Running 1 test case...
*** No errors detected
Segmentation fault (core dumped)

can you elaborate what you mean that nullptr is a valid argument to checked_delete? looking at the code, I see

template<class T> inline void checked_delete(T * x)
{
    // intentionally complex - simplification causes regressions
    typedef char type_must_be_complete[ sizeof(T)? 1: -1 ];
    (void) sizeof(type_must_be_complete);
    delete x;
}
template<class T> inline void checked_array_delete(T * x)
{
    typedef char type_must_be_complete[ sizeof(T)? 1: -1 ];
    (void) sizeof(type_must_be_complete);
    delete [] x;
}

at no point, neither checked_delete nor checked_array_delete actually checks if (x != 0x0). Just wondering if this is expected from the client to checked delete? If yes, then scoped_array should check if the arguments to scoped_array::reset or scoped_array::swap are no 0x0.

Peter Dimov — Fri, 11 Nov 2016 13:17:15 GMT

nullptr is a valid argument for delete. There's no need to check.

I tried your example with the current develop branch of Boost, it may be fixed. I'll try with 1.62.0.

anonymous — Fri, 11 Nov 2016 14:07:20 GMT

my mistake, I shouldn't submit bug reports on a Friday ... I mixed up code versions and thought that boost had a problem. Sorry for the noise and thank you for your patience.