Boost C++ Libraries: Ticket #12719: context test cases and examples segmentation fault when built with mingw-w64 toolchain

status changed; resolution set

olli — Tue, 03 Jan 2017 18:34:14 GMT

status new → closed
resolution → fixed

attachment set

patrick.zani@… — Wed, 04 Jan 2017 22:37:26 GMT

attachment → jump_x86_64_ms_pe_gas.asm.patch

attachment set

anonymous — Wed, 04 Jan 2017 22:37:51 GMT

attachment → ontop_x86_64_ms_pe_gas.asm.patch

status, type, severity changed; resolution deleted

patrick.zani@… — Wed, 04 Jan 2017 22:45:18 GMT

status closed → reopened
type Support Requests → Bugs
resolution fixed
severity Problem → Regression

There are two problems, one in file jump_x86_64_ms_pe_gas.asm and the other in file ontop_x86_64_ms_pe_gas.asm. Register RCX is used instead of RAX.

I fixed the issues and everything works like a charm with mingw-w64 toolchain.

I attached both patch files to this ticket.

olli — Thu, 05 Jan 2017 06:07:15 GMT

Why do you reopen the bug?I've already fixed it and closed the bug report!

status changed; resolution set

olli — Thu, 05 Jan 2017 06:07:36 GMT

status reopened → closed
resolution → fixed

status changed; resolution deleted

p.remmers@… — Mon, 17 Apr 2017 14:30:47 GMT

status closed → reopened
resolution fixed

Unfortunately, the patch does not fix the crashes. When looking at the differences between the masm and the gas version, there is still something missing: + /* restore MMX control- and status-word */ + ldmxcsr 0xa0(%rsp) + /* restore x87 control-word */ + fldcw 0xa4(%rsp)

I'll attach a patch, but I haven't verified it, because boost takes so long to rebuild, and I've had trouble doing an incremental build (the fix didn't end up in the package). I will write an update when the rebuild is done. Sadly, I've seen that the next release is imminent, and this fix will probably not be included until wednesday...

attachment set

p.remmers@… — Mon, 17 Apr 2017 14:31:55 GMT

attachment → boost-1.63.0-fix-context.patch

add missing instructions to asm

p.remmers@… — Mon, 17 Apr 2017 16:22:53 GMT

Ok, so the rebuild is done, and I actually can't say whether that fixed it completely or not. The strange thing is, if you run the program it works and doesn't crash anymore (yay!). However, if you run it under gdb, there will be a SIGSEGV at the ldmxcsr 0xa0(%rsp) instruction in the jump_fcontext function. I don't know whether that's a problem with gdb or whether the problem is not really fixed yet. I can single step over that instruction with visual studio in an msvc build of boost and my test program no problem. I can even use the visual studio debugger and single step over that instruction in the executable that was built by mingw. So I really don't know what's going on here. The way this behaves, I'm going to assume that the problem is basically fixed, and that this is a gdb problem.

olli — Sat, 22 Apr 2017 20:18:13 GMT

could you check branch develop - should fixed now

p.remmers@… — Thu, 27 Apr 2017 22:13:25 GMT

Yes, it seems to work.

It works, I can single step through the context switching disassembly, including the ldmxcsr instruction, and it does not crash. I compiled my test program using both gcc and clang.

I've had some trouble finding it, sucking it out of github (successfully avoided having to learn git until now), and compiling it as an MSYS2 package. I did not completely manage to do it. Somehow after building, the coroutines2 headers are missing, so I switched my test program to use the old coroutines library.

So aside from the other problems, I guess boost.context itself should be good now.

status changed; resolution set

olli — Tue, 13 Jun 2017 13:13:41 GMT

status reopened → closed
resolution → fixed