Boost C++ Libraries: Ticket #12730: windows - static threads library is incompatible with MSVC 2017 RC

attachment set

z7z7z@… — Thu, 05 Jan 2017 20:56:05 GMT

attachment → tss_pe.cpp

Fixed tss_pe.cpp

component changed

viboes — Sun, 19 Feb 2017 11:08:10 GMT

component threads → thread

owner, status changed

viboes — Sun, 19 Feb 2017 11:09:08 GMT

owner changed from Anthony Williams to viboes
status new → assigned

Please, could you provide a patch or even better a github PR?

anonymous — Sun, 19 Feb 2017 18:30:28 GMT

Sorry, I dont't use git, so don't do PRs.

The diff of changes proposed is here: http://pastebin.com/USCA1FN3

The idea is that seems we can't actually generalize that all callbacks are non-returning or that all callbacks are int-returning. We have to differentiate between _I and _V versions.

Note that the fix was not tested on any other VS version.

frank.richter@… — Tue, 21 Feb 2017 09:17:30 GMT

FWIW, looking through some older MSVC CRT sources, back to MSVC 8 the CRT$XI arrays were declared as having int functions - albeit inconsistently, in some places they were treated as void functions. Anyway, perhaps consider extending the change to _MSC_VER >= 1400.

viboes — Tue, 22 Aug 2017 21:53:40 GMT

Could someone having access to Windows and git apply the patch and provide a PR on git?

summary changed

viboes — Thu, 24 Aug 2017 06:00:23 GMT

summary static threads library is incompatible with MSVC 2017 RC → windows - static threads library is incompatible with MSVC 2017 RC

Andrey Semashev — Sun, 27 Aug 2017 16:24:43 GMT

See https://github.com/boostorg/thread/pull/131.

milestone changed

viboes — Sun, 27 Aug 2017 18:59:28 GMT

milestone To Be Determined → Boost 1.66.0

https://github.com/boostorg/thread/commit/584b9c2d2963c7ed2f40d0964b24a6807ce0fe74

status changed; resolution set

viboes — Sat, 16 Sep 2017 16:33:09 GMT

status assigned → closed
resolution → fixed

https://github.com/boostorg/thread/commit/739f8eeb81d74f1a559d8a075985a3f6e8d7b48b