Boost C++ Libraries: Ticket #12949: using sleep_for in a thread context without including boost/thread/thread.hpp yields incorrect behaviour when BOOST_THREAD_HAS_CONDATTR_SET_CLOCK_MONOTONIC is defined

component changed; owner set

John Maddock — Sun, 16 Apr 2017 08:52:35 GMT

owner set to Anthony Williams
component None → thread

viboes — Sat, 29 Apr 2017 02:08:46 GMT

This

#define BOOST_THREAD_VERSION 4
#define BOOST_THREAD_HAS_CONDATTR_SET_CLOCK_MONOTONIC
#include <boost/thread/condition_variable.hpp>
#include "function.h"
void f()
{
    boost::this_thread::sleep_for(boost::chrono::milliseconds(10)); // **
}

shouldn't compile. You need to include

<boost/thread/thread.hpp>

I will why it compiles.

Are you testing on Windows?

owner, status changed

viboes — Sat, 29 Apr 2017 02:08:52 GMT

owner changed from Anthony Williams to viboes
status new → assigned

viboes — Sat, 29 Apr 2017 02:30:28 GMT

Could you be more specific about what incorrect behavior do you get. What is the difference in time?

viboes — Sat, 29 Apr 2017 15:59:53 GMT

https://github.com/boostorg/thread/commit/da83662e1aa3ef045de719f3ad23761c26369675

rkaris@… — Mon, 01 May 2017 10:29:10 GMT

I'm testing on linux in this case. It seems the sleep_for() in the example selects the sleep_for() nanoseconds overload found in boost/thread/pthread/thread_data.hpp instead of the boost/thread/v2/thread.hpp one. With the monotonic clock defined, this seems to lead to a very long sleeping period.

viboes — Thu, 24 Aug 2017 05:54:04 GMT

Sorry for the late response.

Please could you try adding

#include <boost/thread/v2/thread.hpp>

in <boost/thread/pthread/condition_variable.hpp>

#if defined BOOST_THREAD_PROVIDES_INTERRUPTIONS
#include <boost/thread/pthread/thread_data.hpp>
#include <boost/thread/v2/thread.hpp>
#endif

viboes — Thu, 24 Aug 2017 06:22:20 GMT

I have another idea. What about provoking a linker error

Undefined symbols for architecture x86_64:
  "void boost::this_thread::sleep_for<long long, boost::ratio<1l, 1000l> >(boost::chrono::duration<long long, boost::ratio<1l, 1000l> > const&)", referenced from:

milestone changed

viboes — Thu, 24 Aug 2017 06:23:09 GMT

milestone To Be Determined → Boost 1.66.0

status changed; resolution set

viboes — Sat, 26 Aug 2017 09:45:35 GMT

status assigned → closed
resolution → fixed

https://github.com/boostorg/thread/commit/a02f0ec577644ca45cdca20e91cd8cd82e6c2017