attachment set

Fri, 05 Oct 2007 19:23:11 GMT

attachment → add_as_literal.patch

wrap string literals with as_literal

Markus Schöpflin — Fri, 12 Oct 2007 08:30:55 GMT

This patch might fix this particular failure, but I don't think it should be applied, as it only masks the real problem.

The failure comes from the fact, that range currently is not able to correctly handle char[] types. For example:

str = "hello world";
rr  = make_iterator_range( str.begin(), str.begin() + 5 );
BOOST_CHECK( rr == "hello" );

This fails because rr (length 5) is compared to a char array (length 6), as the terminating null character is not correctly handled.

In boost/range/detail/implementation_help.hpp there is code that should deal with this, but it is commented out:

template< class T, std::size_t sz >
inline const T* array_end( const T BOOST_RANGE_ARRAY_REF()[sz] )
{
  /*
  typedef BOOST_RANGE_DEDUCED_TYPENAME boost::mpl::if_c<
    is_same<char,T>::value || is_same<wchar_t,T>::value,
    char_or_wchar_t_array_tag, int >::type tag;
  return array_end<T,sz>( boost_range_array, tag() );
  */
  return boost_range_array + sz;
}

If I enable all the deactivated code in this file, all range tests pass for me on Tru64/CXX.

Thorsten, is there a reason that prevents you from enabling the deactivated code? If you lack the time, do you want me the commit the modified header?

status changed; resolution set

Thorsten Ottosen — Tue, 23 Oct 2007 18:59:10 GMT

status new → closed
resolution → fixed

The bahavior for 1.35 makes your patch the correct code. I have applied it. Many thanks :-)

-Thorsten

Boost C++ Libraries: Ticket #1302: range test as_literal patch

attachment set

status changed; resolution set