Boost C++ Libraries: Ticket #1305: Patch to improve support for the CodeGear (Borland) 5.9.2 compiler

attachment set

Nicola Musatti — Sun, 07 Oct 2007 21:53:35 GMT

attachment → parameter_boost071007.diff

attachment set

Nicola Musatti — Sun, 07 Oct 2007 21:54:12 GMT

attachment → parameter_libs071007.diff

owner changed

Nicola Musatti — Thu, 11 Oct 2007 21:11:27 GMT

owner changed from Daniel Wallin to Nicola Musatti

status changed; resolution set

Nicola Musatti — Sat, 13 Oct 2007 21:42:19 GMT

status new → closed
resolution → fixed

Applied

status changed; resolution deleted

Dave Abrahams — Mon, 15 Oct 2007 20:28:11 GMT

status closed → reopened
resolution fixed

Nicola,

I'm not sure this is really the right patch. Shouldn't Borland have BOOST_NO_SFINAE set? Please feel free to close the ticket again if not.

status changed; resolution set

Nicola Musatti — Mon, 15 Oct 2007 20:46:07 GMT

status reopened → closed
resolution → fixed

I'm aware that this patch is rather ugly. However bcc 5.9.2 does implement SFINAE, although it still has a few problems with it. I tried both alternatives with 1.34 and unsetting BOOST_NO_SFINAE while adding specific workarounds here and there was the combination that got best regression results.

I expect this is even more so with 1.35 as many libraries have since adopted SFINAE to tweak their interface. The availability of SFINAE is the single most common reason for tests that pass with 5.9.2, but fail with previous compilers.

Dave Abrahams — Mon, 15 Oct 2007 23:26:03 GMT

OK, then if you can find the time, I would prefer then to have another configuration macro (parameter-library-specific if no other libs need it) for this purpose. Code repetition is evil, even PP code.