Boost C++ Libraries: Ticket #13077: Linking to static 64bit libboost_thread fails DLL initialization

Fri, 16 Jun 2017 08:26:44 GMT

Maximum attachment size was mere few hundred kb's so I'm linking stuff here. Also I can't use proper urls as Trac will reject my comment as spam.. sigh.

project

ikonen.me/boostthread/boostproblem.zip

Some debug screencaptures

ikonen.me/boostthread/launcherror.png
ikonen.me/boostthread/dllinitfailure.png
ikonen.me/boostthread/vs_debugoutput.png

Sun, 18 Jun 2017 20:37:07 GMT

Traced the error to a call to PVAPI on_tls_prepare(). This function gets called by _initterm_e that expects it to return 0 on success.

However in boost PVAPI is defined as void return type. I think this test is wrong for _MSC_VER 1910 in tss_pe.cpp.

  #if (_MSC_VER < 1300) || (_MSC_VER > 1900) // 1300 == VC++ 7.0, 1900 == VC++ 14.0
        typedef void (__cdecl *_PVFV)();
        #define INIRETSUCCESS
        #define PVAPI void __cdecl
    #else
        typedef int (__cdecl *_PVFV)();
        #define INIRETSUCCESS 0
        #define PVAPI int __cdecl
    #endif

The runtime initializer function is supposed to return an int

/C/Program Files (x86)  $ find . -name "*.h" -print0|xargs -0 grep _PIFV | grep typedef
find: ‘./Google/CrashReports’: Permission denied
./Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/crt/src/vcruntime/internal_shared.h:    typedef int  (__cdecl* _PIFV)(void);
./Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/crt/src/vcruntime/minternal.h:    typedef int         (__clrcall* _PIFVM)(void);
./Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/crt/src/vcruntime/vcruntime_internal.h:typedef int (__cdecl* _PIFV)(void);
./Microsoft Visual Studio/Shared/14.0/VC/crt/src/vcruntime/internal_shared.h:    typedef int  (__cdecl* _PIFV)(void);
./Microsoft Visual Studio/Shared/14.0/VC/crt/src/vcruntime/minternal.h:    typedef int         (__clrcall* _PIFVM)(void);
./Microsoft Visual Studio/Shared/14.0/VC/crt/src/vcruntime/vcruntime_internal.h:typedef int (__cdecl* _PIFV)(void);
./Windows Kits/10/Include/10.0.10240.0/ucrt/corecrt_startup.h:typedef int  (__cdecl* _PIFV)(void);
./Windows Kits/10/Include/10.0.15063.0/ucrt/corecrt_startup.h:typedef int  (__cdecl* _PIFV)(void);

Mon, 19 Jun 2017 08:33:17 GMT

This problem has been fixed in commit: https://github.com/boostorg/thread/commit/676521808d2fea63afcf295d8edb6f55df90f97a

owner, status changed

viboes — Sat, 24 Jun 2017 14:32:11 GMT

owner changed from Anthony Williams to viboes
status new → assigned

status, milestone changed; resolution set

viboes — Tue, 22 Aug 2017 21:59:37 GMT

status assigned → closed
resolution → fixed
milestone To Be Determined → Boost 1.65.0