Boost C++ Libraries: Ticket #13181: Boost test can't compare classes which have begin and end but not const_iterator

attachment set

marc@… — Tue, 29 Aug 2017 19:48:51 GMT

Raffi Enficiaud — Tue, 29 Aug 2017 21:34:44 GMT

Thanks for the report and the patch, will apply for 1.66. A couple of questions:

when you say "fails because s does not contain member types ...", does it mean compilation failure or test failure?
in 1.65, the behaviour changed to check only for the existence of begin/end, while up to 1.64, it was required to have also value_type and const_iterator (as well as size). In your case, that would mean that your class will switch to the collection comparison, while you are providing operator== and I guess you expect that this operator will be used. What is your suggestion?

As a workaround, does this

BOOST_TEST((s1==s2));

work as you expect?

Raffi Enficiaud — Tue, 29 Aug 2017 21:38:50 GMT

marc@… — Wed, 30 Aug 2017 14:24:40 GMT

I would prefer doing collection comparison for the better test failure messages, but it's fine if it uses the user-provided equality operator.

The workaround does work.

Raffi Enficiaud — Wed, 06 Sep 2017 10:32:35 GMT

Merged to branch topic/13181-collection-compare-missing-typename, but tests are failing, I will check

Raffi Enficiaud — Sun, 12 Nov 2017 15:59:26 GMT

Building now

Raffi Enficiaud — Thu, 18 Jan 2018 14:21:08 GMT

Raffi Enficiaud — Mon, 12 Feb 2018 08:18:30 GMT

In master