Boost C++ Libraries: Ticket #13189: copy throws exception from a function defined as noexcept

Sun, 15 Oct 2017 02:14:24 GMT

i want to work on this bug

Mon, 16 Oct 2017 13:20:53 GMT

can i get more information regarding this bug?

kukkerman@… — Thu, 09 Nov 2017 23:27:02 GMT

The root cause of the problem is that copy(from, to) calls detail::copy(from, to) but the declaration of detail::copy is:

void copy(const path& from, const path& to, system::error_code* ec=0);

That way ec will be a null pointer. The next call in the chain in case of a regular file will be copy_file(from, to, fs::copy_option::fail_if_exists, *ec) Looking at the declaration of copy_file

void copy_file(const path& from, const path& to,   // See ticket #2925
               BOOST_SCOPED_ENUM(copy_option) option, system::error_code& ec) BOOST_NOEXCEPT

we can see that ec will be a null reference. The next call will be detail::copy_file(from, to, static_cast<detail::copy_option>(option), &ec) which finally calls the function error:

bool error(err_t error_num, error_code* ec, const char* message)
  {
    if (!error_num)
    {
      if (ec != 0) ec->clear();
    }
    else
    { //  error
      if (ec == 0)
        BOOST_FILESYSTEM_THROW(filesystem_error(message,
          error_code(error_num, system_category())));
      else
        ec->assign(error_num, system_category());
    }
    return error_num != 0;
  }

which will throw an exception because ec is a null pointer. This exception will propagate up to

void copy_file(const path& from, const path& to,   // See ticket #2925
               BOOST_SCOPED_ENUM(copy_option) option, system::error_code& ec) BOOST_NOEXCEPT

which is a noexcept function.

Sat, 11 Nov 2017 15:07:31 GMT

After running a few tests not just filesystem::copy_file but filesystem::copy_symlink and filesystem::copy_directory functions are affected depending on what kind of file from points to. All of these errors can easily be fixed by rewriting filesystem::detail::copy to call functions defined in filesystem::detail namespace instead of filesystem namespace. Because I was unable to attach a patch file to the ticket I'm pasting the patched filesystem::detail::copy function here:

  BOOST_FILESYSTEM_DECL
  void copy(const path& from, const path& to, system::error_code* ec)
  {
    file_status s(symlink_status(from, *ec));
    if (ec != 0 && *ec) return;
    if(is_symlink(s))
    {
      copy_symlink(from, to, ec);
    }
    else if(is_directory(s))
    {
      copy_directory(from, to, ec);
    }
    else if(is_regular_file(s))
    {
      copy_file(from, to, fs::detail::copy_option::fail_if_exists, ec);
    }
    else
    {
      if (ec == 0)
        BOOST_FILESYSTEM_THROW(filesystem_error("boost::filesystem::copy",
          from, to, error_code(BOOST_ERROR_NOT_SUPPORTED, system_category())));
      ec->assign(BOOST_ERROR_NOT_SUPPORTED, system_category());
    }
  }