Boost C++ Libraries: Ticket #13354: xml_iarchive destructor calls abort()

anonymous — Sat, 13 Jan 2018 17:54:49 GMT

I am having the same problem. I am loading a polymorphic object from an xml archive like this:

std::ifstream file(filename);
boost::archive::xml_iarchive iarchive(file);
Preferences * ptr;
iarchive >> boost::serialization::make_nvp("preferences", ptr);
return std::unique_ptr<Preferences>(ptr);

and it crashes after successfully reading the object.

It works with Boost 1.65. I am using GCC 6.4 on NixOS.

steto84@… — Fri, 26 Jan 2018 10:50:43 GMT

seems that the problem is due to the following portion of code in basic_xml_grammar.ipp:

if(is.fail()){
            boost::serialization::throw_exception(
                boost::archive::archive_exception(
                    archive_exception::input_stream_error,
                    std::strerror(errno)
                )
            );
        }

reverting the file to the previous version seems to solve the problem:

 if(is.fail()){
            return false;
        }

Sat, 17 Feb 2018 14:55:53 GMT

probably a duplicate of #13400

Sat, 17 Feb 2018 15:31:08 GMT

ok, the problem seems to be that the end tag </boost_serialization> is missing.

try to apply the suggestion from http://boost.2283326.n4.nabble.com/the-boost-xml-serialization-to-a-stringstream-does-not-have-an-end-tag-td2580772.html

enclose the xml_oarchive in its own scope, so that its destructor is called before calling xml.str();

maybe boost could be more tolerant in this case, and not choke if the end tag is missing?