id,summary,reporter,owner,description,type,status,milestone,component,version,severity,resolution,keywords,cc
13455,path_from_handle using GetModuleFileNameW in wrong way,oleg.dolgov@…,Andrey Semashev,"boost\dll\detail\windows\path_from_handle.hpp

{{{
        boost::detail::winapi::GetModuleFileNameW(handle, path_hldr, 
            DEFAULT_PATH_SIZE_);
        ec = last_error_code();
        if (!ec) {
            return boost::filesystem::path(path_hldr);
        }
}}}

The problem here is that code doesn't analyze return code.
If GetLastError() was dirty before a call this code will fail even if GetModuleFileNameW() will success.
Yes, on success, GetModuleFileNameW() doesn't reset last error to ERROR_SUCCESS.
",Bugs,closed,To Be Determined,winapi,Boost 1.66.0,Problem,invalid,,